Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test updated for State of Tic Tac Toe: Corrects an invalid game state #1129

Merged
merged 3 commits into from
May 2, 2022

Conversation

chriseyre2000
Copy link
Contributor

This fixes one of the tac-tac-toe games.

The game had the same number of X's and O's while X went first and won.
This is therefore an invalid game state but is used to test simple victory.

The test specifications have been updated so this matches the new version.

@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2022

Thank you for contributing to exercism/elixir 💜 🎉. This is an automated PR comment 🤖 for the maintainers of this repository that helps with the PR review process. You can safely ignore it and wait for a maintainer to review your changes.

Based on the files changed in this PR, it would be good to pay attention to the following details when reviewing the PR:

  • General steps

    • 🏆 Does this PR need to receive a label with a reputation modifier (x:size/{tiny,small,medium,large,massive})? (A medium reputation amount is awarded by default, see docs)
  • Any exercise changed

    • 👤 Does the author of the PR need to be added as an author or contributor in <exercise>/.meta/config.json (see docs)?
    • 🔬 Do the analyzer and the analyzer comments exist for this exercise? Do they need to be changed?
    • 📜 Does the design file (<exercise>/.meta/design.md) need to be updated to document new implementation decisions?
  • Practice exercise changed

    • 🌲 Do prerequisites, practices, and difficulty in config.json need to be updated?
    • 🧑‍🏫 Are the changes in accordance with the community-wide problem specifiations?
  • Practice exercise tests changed

    • ⚪️ Are all tests except the first one skipped?
    • 📜 Does <exercise>/.meta/tests.toml need updating?

Automated comment created by PR Commenter 🤖.

@chriseyre2000 chriseyre2000 changed the title Test updated to match spec Test updated for State of Tic Tac Toe: Corrects an invalid game state May 2, 2022
@angelikatyborska
Copy link
Member

Thanks! But you also need to update tests.toml via configlet. Take a look at this issue: #1027 (step 1 and step 3.3 apply here)

@jiegillet
Copy link
Contributor

There are 3 missing test cases, the 2 about invalid boards have actually been added, but I forgot to update the tests.toml.

Copy link
Contributor

@jiegillet jiegillet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woah, you went above and beyond and changed all the test names as well!
Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants