docs: add general labels documentation for issues and PRs #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc: @expressjs/triagers |
UlisesGascon
approved these changes
Feb 25, 2025
wesleytodd
approved these changes
Mar 4, 2025
| | -------------------- | ----------------------------------------------------------------------------------- | | ||
| | `bug` | Denotes confirmed bugs. | | ||
| | `duplicate` | A duplicate issue. | | ||
| | `enhancement` | An issue requesting an enhancement. | |
There was a problem hiding this comment.
Suggested change
| | `enhancement` | An issue requesting an enhancement. | | |
| | `enhancement` | An issue requesting or implementing an enhancement. | |
| | `bug` | Denotes confirmed bugs. | | ||
| | `duplicate` | A duplicate issue. | | ||
| | `enhancement` | An issue requesting an enhancement. | | ||
| | `help wanted` | Extra help may be needed to resolve this issue. | |
There was a problem hiding this comment.
Suggested change
| | `help wanted` | Extra help may be needed to resolve this issue. | | |
| | `help wanted` | Help from the community is requested to assist in resolving this issue. | |
| | `enhancement` | An issue requesting an enhancement. | | ||
| | `help wanted` | Extra help may be needed to resolve this issue. | | ||
| | `invalid` | This is not a proper issue report, request, or question. | | ||
| | `question` | For issues where the issuer is asking something. | |
There was a problem hiding this comment.
We have been moving these into discussions, which IMO is better than using a label. Could we just remove this?
| | `tests` | This issue pertains to the tests themselves. | | ||
| | `deprecate` | Issue is about a feature that is pending future removal. | | ||
| | `release` | A tracking issue for a specific release milestone. | | ||
| | `ideas` | Marks an issue which is primarily an idea. | |
There was a problem hiding this comment.
I am not sure how this is different from enhancement, maybe we could consolidate into one or the other?
| | `needs tests` | This pull request needs tests to be added. | | ||
| | `needs docs` | This pull request needs documentation to be added. | | ||
| | `needs rebase` | This pull request needs rebase to be added. | | ||
| | `future` | An issue which should be resolved in a future release. | |
There was a problem hiding this comment.
I would rather drop this in favor of specific semver major tags.
| | `future` | An issue which should be resolved in a future release. | | ||
| | `deps` | Marks a dependancy-related issue or pull request. | | ||
| | `low priority` | Denotes a low-priority issue. | | ||
| | `question` | Issues that look for answers. | |
There was a problem hiding this comment.
This line is duplicated from line 12.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was discussed in #294 about having the labels documented at the organizational level, so that new triagers know how to use them. Part of this was extracted from https://github.com/jshttp/style-guide?tab=readme-ov-file#issue-label-use.