Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add general labels documentation for issues and PRs #342

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 38 additions & 0 deletions docs/triage/labels.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
# General labels

Express has the following labels available to tag each issue and PR that has been opened

| Name | Description |
| -------------------- | ----------------------------------------------------------------------------------- |
| `bug` | Denotes confirmed bugs. |
| `duplicate` | A duplicate issue. |
| `enhancement` | An issue requesting an enhancement. |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| `enhancement` | An issue requesting an enhancement. |
| `enhancement` | An issue requesting or implementing an enhancement. |

| `help wanted` | Extra help may be needed to resolve this issue. |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| `help wanted` | Extra help may be needed to resolve this issue. |
| `help wanted` | Help from the community is requested to assist in resolving this issue. |

| `invalid` | This is not a proper issue report, request, or question. |
| `question` | For issues where the issuer is asking something. |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have been moving these into discussions, which IMO is better than using a label. Could we just remove this?

| `wontfix` | Marks an issue that will not be fixed. |
| `docs` | This issue pertains to the documentation or code comments. |
| `investigate` | Requires further investigation. |
| `tests` | This issue pertains to the tests themselves. |
| `deprecate` | Issue is about a feature that is pending future removal. |
| `release` | A tracking issue for a specific release milestone. |
| `ideas` | Marks an issue which is primarily an idea. |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure how this is different from enhancement, maybe we could consolidate into one or the other?

| `discuss` | This issue should remain open to discussion for a while. |
| `needs tests` | This pull request needs tests to be added. |
| `needs docs` | This pull request needs documentation to be added. |
| `needs rebase` | This pull request needs rebase to be added. |
| `future` | An issue which should be resolved in a future release. |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather drop this in favor of specific semver major tags.

| `deps` | Marks a dependancy-related issue or pull request. |
| `low priority` | Denotes a low-priority issue. |
| `question` | Issues that look for answers. |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is duplicated from line 12.

| `tc agenda` | Issues that will be discussed in the TC meetings. |
| `top priority` | Issues that will be discussed in the working sessions. |
| `fast track` | PRs that are quick changes, like fixing a spelling mistake. |
| `meta` | Issues and PRs related to the general management of the project. |
| `semver-major` | PRs that have a breaking change. |
| `semver-minor` | PRs that add a new feature and do not break compatibility. |
| `semver-patch` | PRs that fix a bug in the code without breaking compatibility. |
| `feedback` | PRs that require feedback from the community. |
| `require-triage` | Issues and PRs that have been opened but have not been reviewed for the first time. |
| `awaiting more info` | Issues that require more information for better understanding. |
| `good first issue` | Issues suitable for newcomers to fix |