-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove download size badges #6266
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I agree with you here, but I think this should even be a bit more drastic - we should have another readme used in the package.json
there is other assets that could be removed but I think we can have a side discussion about that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am neutral to this change 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
3c99def
to
f960e35
Compare
I missed that this was added in #5619 and would have opposed it if I had noticed. These badges are misleading in too many cases to make it worth including. Having seen some of the most wild projects and the impact of install time, I can confidently say that publishing more versions (aka the packument gets larger) is much worse of a problem than all but the most absurd cases of tarball size.
Anyway, it came up here so I thought I would open this PR to discuss.