Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

5.1.0 #6425

Merged
merged 1 commit into from
Mar 31, 2025
Merged

5.1.0 #6425

merged 1 commit into from
Mar 31, 2025
+19 −26

Conversation

wesleytodd
Copy link
Member

@wesleytodd wesleytodd commented Mar 28, 2025 •
edited by UlisesGascon
Loading

What's Changed

New Contributors

Full Changelog: 5.0.1...master

@wesleytodd wesleytodd mentioned this pull request Mar 28, 2025
Closed
68 tasks
@wesleytodd
Copy link
Member Author

Note that the intent here is for this to be the first v5 release published as latest.

Phillip9587
Phillip9587 requested changes Mar 28, 2025
View reviewed changes
Copy link
Contributor

@Phillip9587 Phillip9587 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest removing the following lines from the HISTORY.md file:

deps: nyc@^17.1.0  
deps: mocha@^10.7.3  
deps: marked@^15.0.3  
deps: express-session@^1.18.1  
deps: ejs@^3.1.10  
deps: connect-redis@^8.0.1  
deps: supertest@^6.3.4

These are devDependencies and, in my opinion, shouldn’t be included in the changelog. Including them might create confusion for users, as they don’t impact the runtime behavior of the package.

@wesleytodd
Copy link
Member Author

I suggest removing the following lines from the HISTORY.md file:

Agreed! I actually did a review and almost decided to remove a few other lines that were in there for the same reason. I really can't wait until we can stop with this madness and just automate it. I will go through and remove those and maybe a few of the others I was thinking didn't need to be there as well.

@wesleytodd
Copy link
Member Author

Cleaned up the history.md and re-organized it a bit. Let me know what y'all think.

@bjohansebas bjohansebas requested a review from Phillip9587 March 28, 2025 18:32
bjohansebas
bjohansebas approved these changes Mar 28, 2025
View reviewed changes
Copy link
Member

@bjohansebas bjohansebas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@wesleytodd
Copy link
Member Author

wesleytodd commented Mar 28, 2025 •
edited
Loading

We have two remaining items we want to have ready for this release, just want to call them out here:

  1. A decision document on our LTS strategy
  2. A blog post about the release, going latest, and some info about our LTS plan

I started one, and will start the other tomorrow morning. Anything anyone can do to help get these ready in time for a planned release on Monday would be awesome! Thanks everyone for the great work!

@wesleytodd
Copy link
Member Author

Opened a PR for a blog post: expressjs/expressjs.com#1849

@bjohansebas bjohansebas mentioned this pull request Mar 29, 2025
Merged
@wesleytodd wesleytodd merged commit cd7d439 into master Mar 31, 2025
23 checks passed
@panva
Copy link

panva commented Mar 31, 2025

This is big, congratulations to everyone involved 🎉

@bjohansebas bjohansebas deleted the release/5.1.0 branch March 31, 2025 16:26
@karlhorky karlhorky mentioned this pull request Apr 1, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@UlisesGascon UlisesGascon UlisesGascon approved these changes

@dpopp07 dpopp07 dpopp07 approved these changes

@Phillip9587 Phillip9587 Phillip9587 approved these changes

@bjohansebas bjohansebas bjohansebas approved these changes

Assignees
No one assigned
Labels
5.x release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@wesleytodd @panva @UlisesGascon @dpopp07 @Phillip9587 @bjohansebas