update rtl version to 16.1.0 and updated types/react to 19 #13725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MatanBobi could you please review this |
|
@iansu could you please take a look, thanks ! |
|
@MatanBobi could you please review this, thanks ! |
|
My review won't help here.. I have no permissions in this repo. I also have a PR regarding this. |
rickhanlonii
added a commit
to MatanBobi/create-react-app
that referenced
this pull request
Jan 28, 2025
Co-authored-by: Rajhans Jadhao <[email protected]>
|
Merged into #13738 |
karlhorky
pushed a commit
to upleveled/create-react-app
that referenced
this pull request
Mar 20, 2025
Co-authored-by: Rajhans Jadhao <[email protected]>
karlhorky
added a commit
to upleveled/create-react-app
that referenced
this pull request
Mar 20, 2025
* fix(babel-preset-react-app): add missing dependency (facebook#12364) In facebook#11318 a change was made to `babel-preset-react-app` to require `@babel/plugin-proposal-private-property-in-object`, but no such dependency was added to `package.json`. This fixes that mistake by adding the dependency. * Migrate from Azure Pipelines to GitHub Actions (facebook#13222) Beyond just a pure migration, this also: - Drops Node 14 usage from CI (which also removes the need for explicit npm 8 installs) - Removes the "old node" test, which just checked that installing on old node failed. We shouldn't need to test that - Consolidates the build & test workflows so we don't end up with a proliferation of workflows. * Update running-tests.md Update running-tests * chore: upgrade RTL version to avoid peer-deps mismatch * Update types from facebook#13725 Co-authored-by: Rajhans Jadhao <[email protected]> * Fix tests * Fix e2e tests * Add act * try this instead * update react-scripts react devDep * idk * Update tests * skip svg component test * Deprecate Create React App officially by changing the README, and adding a message on init (facebook#17003) It's probably time to make this project document its status as being deprecated and not recommended for production usage. To change it: - I opted to add a header to the README saying its over and you should go look at https://react.dev/learn/start-a-new-react-project - I left a note saying that if you are following, it is maybe worth carrying on. While I hear react 19 doesn't work with CRA, I wouldn't be surprised that a good chunk of tutorials would still work. Open to being a bit more hard-lined there but there was a lot of great resources for learning react in that era and it seems like a waste to be making people stop early? - I added a message inside the CLI, it shows once and says "don't use this, use the stuff in https://react.dev/learn/start-a-new-react-project" --------- Co-authored-by: Ricky <[email protected]> Co-authored-by: Rick Hanlon <[email protected]> * Update deprecation link (facebook#17015) Updates to a shortlink that we can redirect as needed for old versions. Currently 404 * Add deprecation to website (facebook#17008) - Adds a banner with deprecation notice - Adds a noindex meta tag to home page to remove from search - Add og meta info for when noindex is ignored * Publish - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] * Migrate from Azure Pipelines to GitHub Actions (facebook#13222) Beyond just a pure migration, this also: - Drops Node 14 usage from CI (which also removes the need for explicit npm 8 installs) - Removes the "old node" test, which just checked that installing on old node failed. We shouldn't need to test that - Consolidates the build & test workflows so we don't end up with a proliferation of workflows. * Update running-tests.md Update running-tests * chore: upgrade RTL version to avoid peer-deps mismatch * Update types from facebook#13725 Co-authored-by: Rajhans Jadhao <[email protected]> * Fix tests * Fix e2e tests * Add act * try this instead * update react-scripts react devDep * idk * Update tests * skip svg component test * Deprecate Create React App officially by changing the README, and adding a message on init (facebook#17003) It's probably time to make this project document its status as being deprecated and not recommended for production usage. To change it: - I opted to add a header to the README saying its over and you should go look at https://react.dev/learn/start-a-new-react-project - I left a note saying that if you are following, it is maybe worth carrying on. While I hear react 19 doesn't work with CRA, I wouldn't be surprised that a good chunk of tutorials would still work. Open to being a bit more hard-lined there but there was a lot of great resources for learning react in that era and it seems like a waste to be making people stop early? - I added a message inside the CLI, it shows once and says "don't use this, use the stuff in https://react.dev/learn/start-a-new-react-project" --------- Co-authored-by: Ricky <[email protected]> Co-authored-by: Rick Hanlon <[email protected]> * Update deprecation link (facebook#17015) Updates to a shortlink that we can redirect as needed for old versions. Currently 404 * Add deprecation to website (facebook#17008) - Adds a banner with deprecation notice - Adds a noindex meta tag to home page to remove from search - Add og meta info for when noindex is ignored * Publish - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] - [email protected] * Disable deprecation warning and version check * Bump version * Disable deleting folder after error * Fix babel-plugin-named-asset-import version number * Bump @upleveled/create-react-app to 5.1.2 * Bump version of @upleveled/react-scripts to 5.1.1 * Add back call to createApp() * Bump version of @upleveled/create-react-app to 5.1.3 * Revert to published versions of react-scripts dependencies * Bump version of @upleveled/react-scripts to 5.1.2 * Allow pnpm to build @parcel/watcher, ignore core-js builds * Bump version of @upleveled/cra-template to 1.3.1 * Remove pnpm config from package.json, bump to @upleveled/[email protected] * Add pnpm built packages configuration in `package.json` * Bump @upleveled/create-react-app to 5.1.4 --------- Co-authored-by: Brian Donovan <[email protected]> Co-authored-by: Paul O’Shannessy <[email protected]> Co-authored-by: Olexandr Radovenchyk <[email protected]> Co-authored-by: Edgardo Avilés-López <[email protected]> Co-authored-by: Matan Borenkraout <[email protected]> Co-authored-by: Rick Hanlon <[email protected]> Co-authored-by: Rajhans Jadhao <[email protected]> Co-authored-by: Ricky <[email protected]> Co-authored-by: Orta Therox <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updating RTL version to latest to support React 19