Update from upstream, remove deprecation notice + version checking #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In facebook#11318 a change was made to `babel-preset-react-app` to require `@babel/plugin-proposal-private-property-in-object`, but no such dependency was added to `package.json`. This fixes that mistake by adding the dependency.
Beyond just a pure migration, this also: - Drops Node 14 usage from CI (which also removes the need for explicit npm 8 installs) - Removes the "old node" test, which just checked that installing on old node failed. We shouldn't need to test that - Consolidates the build & test workflows so we don't end up with a proliferation of workflows.
Update running-tests
Update running-tests.md
Co-authored-by: Rajhans Jadhao <[email protected]>
…rsion-rtl-16 fix: upgrade RTL version to avoid peer-deps mismatch
…ing a message on init (facebook#17003) It's probably time to make this project document its status as being deprecated and not recommended for production usage. To change it: - I opted to add a header to the README saying its over and you should go look at https://react.dev/learn/start-a-new-react-project - I left a note saying that if you are following, it is maybe worth carrying on. While I hear react 19 doesn't work with CRA, I wouldn't be surprised that a good chunk of tutorials would still work. Open to being a bit more hard-lined there but there was a lot of great resources for learning react in that era and it seems like a waste to be making people stop early? - I added a message inside the CLI, it shows once and says "don't use this, use the stuff in https://react.dev/learn/start-a-new-react-project" --------- Co-authored-by: Ricky <[email protected]> Co-authored-by: Rick Hanlon <[email protected]>
Updates to a shortlink that we can redirect as needed for old versions. Currently 404
- Adds a banner with deprecation notice - Adds a noindex meta tag to home page to remove from search - Add og meta info for when noindex is ignored
Beyond just a pure migration, this also: - Drops Node 14 usage from CI (which also removes the need for explicit npm 8 installs) - Removes the "old node" test, which just checked that installing on old node failed. We shouldn't need to test that - Consolidates the build & test workflows so we don't end up with a proliferation of workflows.
Update running-tests
Co-authored-by: Rajhans Jadhao <[email protected]>
…ing a message on init (facebook#17003) It's probably time to make this project document its status as being deprecated and not recommended for production usage. To change it: - I opted to add a header to the README saying its over and you should go look at https://react.dev/learn/start-a-new-react-project - I left a note saying that if you are following, it is maybe worth carrying on. While I hear react 19 doesn't work with CRA, I wouldn't be surprised that a good chunk of tutorials would still work. Open to being a bit more hard-lined there but there was a lot of great resources for learning react in that era and it seems like a waste to be making people stop early? - I added a message inside the CLI, it shows once and says "don't use this, use the stuff in https://react.dev/learn/start-a-new-react-project" --------- Co-authored-by: Ricky <[email protected]> Co-authored-by: Rick Hanlon <[email protected]>
Updates to a shortlink that we can redirect as needed for old versions. Currently 404
- Adds a banner with deprecation notice - Adds a noindex meta tag to home page to remove from search - Add og meta info for when noindex is ignored
…te-from-upstream-remove-deprecation-notice-disable-version-checker
karlhorky
deleted the
update-from-upstream-remove-deprecation-notice-disable-version-checker
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5