Update README.md bootstrap 4 #4413
Conversation
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
It's ok
| @@ -768,12 +768,24 @@ Install React Bootstrap and Bootstrap from npm. React Bootstrap does not include | |||
| npm install --save react-bootstrap bootstrap@3 | |||
| ``` | |||
|
|
|||
| For version 4: | |||
There was a problem hiding this comment.
We can probably just replace the Bootstrap 3 instructions with Bootstrap 4. No need to include both.
| For version 4: | ||
|
|
||
| ```sh | ||
| yarn add [email protected] |
There was a problem hiding this comment.
We should change this to the latest version of Bootstrap 4 (currently 4.1.1)
|
The base branch of the PR needs to be changes from |
|
Since Bootstrap 4 is no longer beta, I see no reason in dropping 3 from the docs all together. |
|
Resct-Bootstrap doesn't (yet) support Bootstrap 4. Would it make sense to recommend Reactstrap instead? |
|
I'd be fine switching to |
|
closing because #4703 is merged. |
No description provided.