Skip to content

Update README.md bootstrap 4 #4413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Update README.md bootstrap 4 #4413

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a18e478
Update README.md
walterwhites May 6, 2018
267a680
Update ReadMe v2
walterwhites May 7, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions packages/react-scripts/template/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -768,12 +768,24 @@ Install React Bootstrap and Bootstrap from npm. React Bootstrap does not include
npm install --save react-bootstrap bootstrap@3
```

For version 4:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can probably just replace the Bootstrap 3 instructions with Bootstrap 4. No need to include both.


```sh
npm install bootstrap@4
```

Alternatively you may use `yarn`:

```sh
yarn add react-bootstrap bootstrap@3
```

For version 4:

```sh
yarn add [email protected]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should change this to the latest version of Bootstrap 4 (currently 4.1.1)

```

Import Bootstrap CSS and optionally Bootstrap theme CSS in the beginning of your ```src/index.js``` file:

```js
Expand All @@ -783,6 +795,14 @@ import 'bootstrap/dist/css/bootstrap-theme.css';
// components takes precedence over default styles.
```

For version 4 :

```js
import 'bootstrap/dist/css/bootstrap.css';
import 'bootstrap/dist/css/bootstrap-grid.css';
import 'bootstrap/dist/css/bootstrap-reboot.css';
```

Import required React Bootstrap components within ```src/App.js``` file or your custom component files:

```js
Expand Down