Skip to content

Update to the latest graphsync #373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 13, 2023
Merged

Update to the latest graphsync #373

merged 2 commits into from
Apr 13, 2023

Conversation

gammazero
Copy link
Contributor

Update graphsync to get the latest fixes.

@willscott willscott requested a review from hannahhoward March 29, 2023 20:59
rvagg
rvagg previously approved these changes Mar 30, 2023
@rvagg
Copy link
Member

rvagg commented Mar 30, 2023

those CI failures are pretty persistent across 3 CI re-runs on this, maybe not flakes so we either ought to figure that out, unless @hannahhoward knows whether they genuinely are flaky

@rvagg rvagg dismissed their stale review March 30, 2023 04:56

want to check out flakies

@rvagg
Copy link
Member

rvagg commented Apr 6, 2023

Same failures experienced #374 using an updated graphsync from ipfs/go-graphsync#420 which is based on main there; the failures don't happen on the current master here, so they are new with the updated graphsync.

@codecov-commenter
Copy link

Codecov Report

Merging #373 (11012bc) into master (1a2895d) will decrease coverage by 0.10%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #373      +/-   ##
==========================================
- Coverage   61.38%   61.28%   -0.10%     
==========================================
  Files          30       30              
  Lines        3180     3180              
==========================================
- Hits         1952     1949       -3     
- Misses        999     1002       +3     
  Partials      229      229              
Impacted Files Coverage Δ
channels/channels.go 72.47% <0.00%> (-0.68%) ⬇️
impl/impl.go 51.18% <0.00%> (-0.14%) ⬇️
network/libp2p_impl.go 65.86% <0.00%> (-0.61%) ⬇️

@gammazero gammazero requested a review from rvagg April 13, 2023 18:00
@gammazero gammazero merged commit 131ecef into master Apr 13, 2023
@gammazero gammazero deleted the update-graphsync branch April 13, 2023 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants