feat: MaxLinks for pulls #374
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannahhoward
reviewed
Apr 4, 2023
rvagg
force-pushed
the
rvagg/maxlinks
branch
2 times, most recently
from
5a31334 to
99ba9d3
Compare
|
Failures discussed in #373, they come from the diff between go-graphsync v0.14.0 and the current |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #374 +/- ##
==========================================
+ Coverage 61.28% 61.31% +0.02%
==========================================
Files 30 30
Lines 3180 3200 +20
==========================================
+ Hits 1949 1962 +13
- Misses 1002 1009 +7
Partials 229 229
|
hannahhoward
approved these changes
Apr 22, 2023
hannahhoward
pushed a commit
to filecoin-project/lassie
that referenced
this pull request
Apr 22, 2023
hannahhoward
added a commit
to filecoin-project/lassie
that referenced
this pull request
Apr 22, 2023
* feat: use traversal link budget instead of limitstore Ref: ipfs/go-graphsync#420 Ref: filecoin-project/go-data-transfer#374 * chore(deps): update go-data-transfer v2.0.0-rc7 * style(lint): fix fmt --------- Co-authored-by: hannahhoward <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses ipfs/go-graphsync#420
Further comments in Lassie