Skip to content

fix(ui localizations): fixed typos and added translations to 'pt' (Portugese) #414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

JPBotelho
Copy link
Contributor

@JPBotelho JPBotelho commented Oct 12, 2024

Description

Some of the strings were not translated to 'pt' and were still in English.

I also changed:

  1. 'e-mail' to 'email', to be consistent with english
  2. 'Uso um dos métodos' to 'Use um dos métodos' (typo)
  3. 'Informar o código SMS' to 'Introduza o código SMS' (typo)
  4. 'Enviamos um link' to 'Enviámos um link' (typo)

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See [Contributor Guide]).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • All unit tests pass (melos run test:unit:all doesn't fail).
  • I read and followed the [Flutter Style Guide].
  • I signed the [CLA].
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@JPBotelho JPBotelho force-pushed the jcosta/pt-localizations branch from cee9e17 to c14a02c Compare October 12, 2024 15:59
@guilherme-marcello
Copy link

Hello @JPBotelho,

Everything looks good overall, thank you for adding this! The corrections and consistency improvements to the translation are on point.

However, I have a couple of suggestions that could make the translation sound more natural in Portuguese:

  • unlinkProviderAlertMessage: I believe "Tem a certeza que quer desassociar este provedor?" might sound more natural and emphatic in Portuguese. The use of "Tem a certeza" reinforces the confirmation aspect of the message.
  • confirmDeleteAccountAlertMessage: Similarly, "Tem a certeza que quer eliminar sua conta?" might be a better translation, as it conveys the seriousness of the action and seeks a strong confirmation from the user.

These suggestions are based on the common usage in Portuguese.

Regards,
Guilherme.

@github-actions github-actions bot added the Needs Attention OP created or responded to issue and it needs attention. label Oct 12, 2024
@JPBotelho JPBotelho force-pushed the jcosta/pt-localizations branch from c14a02c to 1c209e0 Compare October 12, 2024 17:11
@JPBotelho
Copy link
Contributor Author

addressed, "De certeza" changed to "Tem a certeza"

@russellwheatley pinging because I saw you handled other i10n PRs

@russellwheatley russellwheatley changed the title fix(ui localizations): fixed typos and added translations to 'pt' fix(ui localizations): fixed typos and added translations to 'pt' (Portugese) Oct 28, 2024
@russellwheatley russellwheatley merged commit 3609796 into firebase:main Oct 29, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Attention OP created or responded to issue and it needs attention.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants