Skip to content

Create Github templates #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 4, 2017
Merged

Create Github templates #17

merged 4 commits into from
May 4, 2017

Conversation

samtstern
Copy link
Contributor

No description provided.

@hiranya911 hiranya911 self-requested a review May 4, 2017 18:55
Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hiranya911 hiranya911 assigned samtstern and unassigned hiranya911 May 4, 2017
@samtstern samtstern merged commit 8e817ba into io-2017 May 4, 2017
@hiranya911 hiranya911 deleted the gh-templates branch May 4, 2017 19:19
TrCaM added a commit that referenced this pull request May 31, 2019
* Add integration test

* Fix listAppMetadata integration test
TrCaM added a commit that referenced this pull request Jun 4, 2019
… class (#546)

* Added AppMetadata type

* Declare setDisplayName and listAppMetadata (unimplemented)

* Declare listAppMetadata and setDisplayName methods in Project Management class (#12)

* Added AppMetadata type

* Declare setDisplayName and listAppMetadata (unimplemented)

* Update AndroidAppMetadata and IosAppMetadata

* Change AppMetadata to interface and displayName to be optional

* listAppMetadata: implement api request

* listAppMetadata: implement listAppMetadata in ProjectManagement class (#16)

* listAppMetadata: implement listAppMetadata in ProjectManagement class

* Clean up code to address comments

* Fix: non ios/android apps should be listed as PLATFORM_UNKNOWN (#18)

* Add integration test for ProjectManagement.listAppMetadata() (#17)

* Add integration test

* Fix listAppMetadata integration test

* Implement setDisplayName() for ProjectManagement class (#19)

* Implement setDisplayName() for ProjectManagement class

* fix integration test to address comment

* Enable promise support for integration test

* Fix listAppMetadata to match the update on AppMetatdata interface

* Handle nullable displayName and enum string mapping issues

* Update test for null display name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants