Updating Realtime DB Code #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TrCaM
added a commit
that referenced
this pull request
May 31, 2019
TrCaM
added a commit
that referenced
this pull request
Jun 4, 2019
… class (#546) * Added AppMetadata type * Declare setDisplayName and listAppMetadata (unimplemented) * Declare listAppMetadata and setDisplayName methods in Project Management class (#12) * Added AppMetadata type * Declare setDisplayName and listAppMetadata (unimplemented) * Update AndroidAppMetadata and IosAppMetadata * Change AppMetadata to interface and displayName to be optional * listAppMetadata: implement api request * listAppMetadata: implement listAppMetadata in ProjectManagement class (#16) * listAppMetadata: implement listAppMetadata in ProjectManagement class * Clean up code to address comments * Fix: non ios/android apps should be listed as PLATFORM_UNKNOWN (#18) * Add integration test for ProjectManagement.listAppMetadata() (#17) * Add integration test * Fix listAppMetadata integration test * Implement setDisplayName() for ProjectManagement class (#19) * Implement setDisplayName() for ProjectManagement class * fix integration test to address comment * Enable promise support for integration test * Fix listAppMetadata to match the update on AppMetatdata interface * Handle nullable displayName and enum string mapping issues * Update test for null display name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.