Skip to content

MemoryDocumentOverlayCache: add a comment about getOverlays() #3443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 14, 2022
Merged

MemoryDocumentOverlayCache: add a comment about getOverlays() #3443

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ...restore/src/main/java/com/google/firebase/firestore/local/MemoryDocumentOverlayCache.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,9 @@ public Map<DocumentKey, Overlay> getOverlays(ResourcePath collection, int sinceB
@Override
public Map<DocumentKey, Overlay> getOverlays(
String collectionGroup, int sinceBatchId, int count) {
// NOTE: This method is only used by the backfiller, which will not run for memory persistence;
// therefore, this method is being implemented only so that the test suite for
// `LevelDbDocumentOverlayCache` can be re-used by the test suite for this class.
SortedMap<Integer, Map<DocumentKey, Overlay>> batchIdToOverlays = new TreeMap<>();

for (Overlay overlay : overlays.values()) {
Expand Down