Skip to content

MemoryDocumentOverlayCache: add a comment about getOverlays() #3443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 14, 2022
Merged

MemoryDocumentOverlayCache: add a comment about getOverlays() #3443

merged 1 commit into from
Feb 14, 2022

Conversation

dconeybe
Copy link
Contributor

Add a comment to the MemoryDocumentOverlayCache.getOverlays() overload for collection groups about the method not actually being used in production but being implemented only to satisfy unit tests.

This comment was ported from a comment in firebase/firebase-ios-sdk#9330.

@dconeybe
MemoryDocumentOverlayCache.java: add a comment about getOverlays() fo…
ebe6f9b 
…r collectionGroup only being implemented for testing purposes
@dconeybe dconeybe requested a review from wu-hui February 14, 2022 15:41
@dconeybe dconeybe mentioned this pull request Feb 14, 2022
Merged
@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-firestore

    Overall coverage changed from 45.60% (9501fbd) to 45.58% (c047ddb) by -0.01%.

    FilenameBase (9501fbd)Merge (c047ddb)Diff
    DeleteMutation.java95.00%90.00%-5.00%
    PatchMutation.java100.00%98.39%-1.61%
    SetMutation.java97.14%94.29%-2.86%

Test Logs

Notes

  • Commit (c047ddb) is created by Prow via merging PR base commit (9501fbd) and head commit (ebe6f9b).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/6f3mVxgiJt.html

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • firebase-firestore

    TypeBase (9501fbd)Merge (c047ddb)Diff
    aar1.24 MB1.24 MB-1 B (-0.0%)
    apk (release)3.33 MB3.33 MB+4 B (+0.0%)

Test Logs

Notes

  • Commit (c047ddb) is created by Prow via merging PR base commit (9501fbd) and head commit (ebe6f9b).

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/HuoZ0TSojJ.html

@wu-hui wu-hui merged commit b4cc8b1 into master Feb 14, 2022
@wu-hui wu-hui deleted the dconeybe/MemoryDocumentOverlayCacheGetOverlaysCollectionGroupComment branch February 14, 2022 16:03
qdpham13 pushed a commit that referenced this pull request Feb 15, 2022
@dconeybe @qdpham13
MemoryDocumentOverlayCache.java: add a comment about getOverlays() fo…
150449d 
…r collectionGroup only being implemented for testing purposes (#3443)
jeremyjiang-dev pushed a commit that referenced this pull request Mar 9, 2022
@dconeybe @jeremyjiang-dev
MemoryDocumentOverlayCache.java: add a comment about getOverlays() fo…
c1d85cc 
…r collectionGroup only being implemented for testing purposes (#3443)
@firebase firebase locked and limited conversation to collaborators Mar 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wu-hui wu-hui wu-hui approved these changes

Assignees

@wu-hui wu-hui

@dconeybe dconeybe

Labels
api: firestore size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dconeybe @google-oss-bot @wu-hui