Skip to content

DocumentOverlayCacheTestCase.testUpdateDocumentOverlay() added #3463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 18, 2022
Merged

DocumentOverlayCacheTestCase.testUpdateDocumentOverlay() added #3463

merged 2 commits into from
Feb 18, 2022

Conversation

dconeybe
Copy link
Contributor

@dconeybe dconeybe self-assigned this Feb 17, 2022
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 17, 2022 •
edited
Loading

Coverage Report 1

Affected Products

  • firebase-firestore

    Overall coverage changed from 45.55% (62d868a) to 45.58% (81301b0) by +0.02%.

    FilenameBase (62d868a)Merge (81301b0)Diff
    AutoValue_Overlay.java31.82%54.55%+22.73%
    DeleteMutation.java90.00%95.00%+5.00%

Test Logs

Notes

  • Commit (81301b0) is created by Prow via merging PR base commit (62d868a) and head commit (1f6fa76).
  • Run gradle <product>:checkCoverage to produce HTML coverage reports locally. After gradle commands finished, report files can be found under <product-build-dir>/reports/jacoco/.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/DTXxLScLM6.html

@dconeybe dconeybe mentioned this pull request Feb 17, 2022
Merged
@dconeybe dconeybe changed the title DocumentOverlayCacheTestCase.java.testUpdateDocumentOverlay() added DocumentOverlayCacheTestCase.testUpdateDocumentOverlay() added Feb 17, 2022
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Feb 17, 2022 •
edited
Loading

Size Report 1

Affected Products

No changes between base commit (62d868a) and merge commit (81301b0).

Test Logs

Notes

  • Commit (81301b0) is created by Prow via merging PR base commit (62d868a) and head commit (1f6fa76).

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/juWoK6jDMn.html

@dconeybe dconeybe requested a review from wu-hui February 17, 2022 22:10
@wu-hui wu-hui merged commit e8659b5 into master Feb 18, 2022
@wu-hui wu-hui deleted the dconeybe/DocumentOverlayCacheUpdateEntryTest branch February 18, 2022 14:42
jeremyjiang-dev pushed a commit that referenced this pull request Mar 9, 2022
@dconeybe @jeremyjiang-dev
DocumentOverlayCacheTestCase.testUpdateDocumentOverlay() added (#3463)
f904a58 
* DocumentOverlayCacheTestCase.java.testUpdateDocumentOverlay() added, ported from firebase/firebase-ios-sdk@cf04e67

* empty commit to re-run presubmits
@firebase firebase locked and limited conversation to collaborators Mar 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wu-hui wu-hui wu-hui approved these changes

Assignees

@wu-hui wu-hui

@dconeybe dconeybe

Labels
api: firestore size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dconeybe @google-oss-bot @wu-hui