firestore::local::LevelDbDocumentOverlayCache added. #9345
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Report 1Affected ProductsTest Logs |
…lay.pb.cc and document_overlay.pb.h
Coverage Report 1Affected Products
Test Logs |
wu-hui
reviewed
Feb 16, 2022
…in the leveldb key.
…ry for the given document
wu-hui
approved these changes
Feb 18, 2022
…mentOverlayCache::GetOverlays() for collection groups to explain the subtle logic
|
LGTM |
This was referenced Feb 23, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create
LevelDbDocumentOverlayCache, the analogue ofSqliteDocumentOverlayCache.javafrom the Android SDK. The unit tests forLevelDbDocumentOverlayCachere-use the ones forMemoryDocumentOverlayCache(added in #9330), since those tests were written in a manner that enables them to be parameterized.Future PRs will be needed to improve the performance of this new class. The performance of
GetOverlay()is O(log(n)), which is acceptable; however, the performance ofRemoveOverlaysForBatchId(),GetOverlays(const ResourcePath&, int), andGetOverlays(const std::string&, int, std::size_t)are θ(n), where n is the number of overlays in the database for the user, which is unacceptable. Using manual indexing, their performances can be improved to O(m(log(m)) forRemoveOverlaysForBatchId()and O(m) for the twoGetOverlays()methods, where m is the number of overlays that are affected/returned by the methods.Googlers see b/210002758 for details.
#no-changelog