fix: remove null value inclusion from `whereNotEqualTo` and `whereNotIn` filter results #6859

milaGGL · 2025-04-09T21:04:03Z

ported from firebase/firebase-ios-sdk#14704

github-actions · 2025-04-09T21:04:15Z

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

google-oss-bot · 2025-04-09T21:09:40Z

Coverage Report ¹

Affected Products

`firebase-firestore`

Overall coverage changed from 45.77% (70c8e89) to 45.77% (796dd1d) by +0.00%.

Filename	Base (`70c8e89`)	Merge (`796dd1d`)	Diff
DeleteMutation.java	90.48%	95.24%	+4.76%
FieldFilter.java	94.20%	94.37%	+0.16%
LruGarbageCollector.java	97.27%	93.64%	-3.64%
NotInFilter.java	85.71%	88.89%	+3.17%
PatchMutation.java	100.00%	98.39%	-1.61%
SetMutation.java	94.44%	97.22%	+2.78%
Value.java	41.22%	41.48%	+0.25%

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/um1lMEGb5d.html

github-actions · 2025-04-09T21:11:03Z

Test Results

186 files ±0 186 suites ±0 4m 29s ⏱️ -8s
1 235 tests ±0 1 219 ✅ ±0 16 💤 ±0 0 ❌ ±0
2 494 runs ±0 2 462 ✅ ±0 32 💤 ±0 0 ❌ ±0

Results for commit 2fa8a24. ± Comparison against base commit 70c8e89.

♻️ This comment has been updated with latest results.

google-oss-bot · 2025-04-09T21:19:40Z

Size Report ¹

Affected Products

firebase-firestore
Type Base (70c8e89) Merge (796dd1d) Diff
aar 1.45 MB 1.45 MB +54 B (+0.0%)
apk (release) 11.4 MB 11.4 MB +28 B (+0.0%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/6V7SeskilU.html

google-oss-bot · 2025-04-09T21:33:22Z

Startup Time Report ¹

Note: Layout is sometimes suboptimal due to limited formatting support on GitHub. Please check this report on GCS.

Notes

This report is for comparing the base commit (70c8e89) and the CI merge commit (796dd1d)
Please check below reports for each individual commit to find more details (Perfetto traces, histograms, detailed measurements)
- 70c8e89: https://storage.googleapis.com/firebase-sdk-metric-reports/mrQ7sxYYv5/index.html
- 796dd1d: https://storage.googleapis.com/firebase-sdk-metric-reports/yMWvV2aJwK/index.html

Startup Times

`fire-fst`

Device Statistics Distributions

oriole-32

Percentile	`70c8e89`	`796dd1d`	Diff	Significant (?)
p10	255 ±13 μs	267 ±17 μs	+11.9 μs (+4.7%)	NO
p25	264 ±13 μs	277 ±18 μs	+12.9 μs (+4.9%)	NO
p50	277 ±15 μs	297 ±32 μs	+20.6 μs (+7.4%)	NO
p75	308 ±38 μs	348 ±80 μs	+40.9 μs (+13.3%)	NO
p90	352 ±66 μs	466 ±201 μs	+114 μs (+32.4%)	NO

20 test runs in comparison

Commit	Test Runs
`70c8e89`	2025-04-10_19:43:20.185599_ofvb 2025-04-10_19:43:20.185631_CbkX 2025-04-10_19:43:20.185644_xSdJ 2025-04-10_19:43:20.185652_ahSU 2025-04-10_19:43:20.185660_MelI 2025-04-10_19:43:20.185668_rsTl 2025-04-10_19:43:20.185675_pBds 2025-04-10_19:43:20.185681_WXCN 2025-04-10_19:43:20.185688_WkbI 2025-04-10_19:43:20.185694_Yvhm
`796dd1d`	2025-04-10_21:18:02.661090_saFq 2025-04-10_21:18:02.661118_qEqk 2025-04-10_21:18:02.661140_gLma 2025-04-10_21:18:02.661146_CLMo 2025-04-10_21:18:02.661151_WqWh 2025-04-10_21:18:02.661155_KzhU 2025-04-10_21:18:02.661159_tkAp 2025-04-10_21:18:02.661163_BixF 2025-04-10_21:18:02.661166_CPOt 2025-04-10_21:18:02.661171_QIcZ

redfin-30

Percentile	`70c8e89`	`796dd1d`	Diff	Significant (?)
p10	468 ±19 μs	497 ±31 μs	+28.9 μs (+6.2%)	NO
p25	486 ±24 μs	511 ±35 μs	+25.5 μs (+5.2%)	NO
p50	506 ±27 μs	532 ±41 μs	+26.0 μs (+5.1%)	NO
p75	532 ±35 μs	558 ±45 μs	+26.5 μs (+5.0%)	NO
p90	566 ±52 μs	589 ±50 μs	+22.5 μs (+4.0%)	NO

20 test runs in comparison

Commit	Test Runs
`70c8e89`	2025-04-10_19:43:20.185599_ofvb 2025-04-10_19:43:20.185631_CbkX 2025-04-10_19:43:20.185644_xSdJ 2025-04-10_19:43:20.185652_ahSU 2025-04-10_19:43:20.185660_MelI 2025-04-10_19:43:20.185668_rsTl 2025-04-10_19:43:20.185675_pBds 2025-04-10_19:43:20.185681_WXCN 2025-04-10_19:43:20.185688_WkbI 2025-04-10_19:43:20.185694_Yvhm
`796dd1d`	2025-04-10_21:18:02.661090_saFq 2025-04-10_21:18:02.661118_qEqk 2025-04-10_21:18:02.661140_gLma 2025-04-10_21:18:02.661146_CLMo 2025-04-10_21:18:02.661151_WqWh 2025-04-10_21:18:02.661155_KzhU 2025-04-10_21:18:02.661159_tkAp 2025-04-10_21:18:02.661163_BixF 2025-04-10_21:18:02.661166_CPOt 2025-04-10_21:18:02.661171_QIcZ

`timeToInitialDisplay`

Device Statistics Distributions

oriole-32

Percentile	`70c8e89`	`796dd1d`	Diff	Significant (?)
p10	197 ±5 ms	201 ±4 ms	+3.45 ms (+1.7%)	NO
p25	204 ±5 ms	206 ±3 ms	+2.87 ms (+1.4%)	NO
p50	210 ±5 ms	214 ±3 ms	+3.39 ms (+1.6%)	NO
p75	218 ±5 ms	223 ±5 ms	+4.80 ms (+2.2%)	NO
p90	225 ±6 ms	235 ±9.6 ms	+9.79 ms (+4.3%)	NO

20 test runs in comparison

Commit	Test Runs
`70c8e89`	2025-04-10_19:43:20.185599_ofvb 2025-04-10_19:43:20.185631_CbkX 2025-04-10_19:43:20.185644_xSdJ 2025-04-10_19:43:20.185652_ahSU 2025-04-10_19:43:20.185660_MelI 2025-04-10_19:43:20.185668_rsTl 2025-04-10_19:43:20.185675_pBds 2025-04-10_19:43:20.185681_WXCN 2025-04-10_19:43:20.185688_WkbI 2025-04-10_19:43:20.185694_Yvhm
`796dd1d`	2025-04-10_21:18:02.661090_saFq 2025-04-10_21:18:02.661118_qEqk 2025-04-10_21:18:02.661140_gLma 2025-04-10_21:18:02.661146_CLMo 2025-04-10_21:18:02.661151_WqWh 2025-04-10_21:18:02.661155_KzhU 2025-04-10_21:18:02.661159_tkAp 2025-04-10_21:18:02.661163_BixF 2025-04-10_21:18:02.661166_CPOt 2025-04-10_21:18:02.661171_QIcZ

redfin-30

Percentile	`70c8e89`	`796dd1d`	Diff	Significant (?)
p10	224 ±2 ms	248 ±5 ms	+24.4 ms (+10.9%)	YES
p25	230 ±2 ms	255 ±6 ms	+25.5 ms (+11.1%)	MAYBE
p50	237 ±2 ms	265 ±7 ms	+27.7 ms (+11.7%)	MAYBE
p75	245 ±2 ms	277 ±13 ms	+32.4 ms (+13.2%)	NO
p90	253 ±3 ms	297 ±26 ms	+43.5 ms (+17.2%)	NO

20 test runs in comparison

Commit	Test Runs
`70c8e89`	2025-04-10_19:43:20.185599_ofvb 2025-04-10_19:43:20.185631_CbkX 2025-04-10_19:43:20.185644_xSdJ 2025-04-10_19:43:20.185652_ahSU 2025-04-10_19:43:20.185660_MelI 2025-04-10_19:43:20.185668_rsTl 2025-04-10_19:43:20.185675_pBds 2025-04-10_19:43:20.185681_WXCN 2025-04-10_19:43:20.185688_WkbI 2025-04-10_19:43:20.185694_Yvhm
`796dd1d`	2025-04-10_21:18:02.661090_saFq 2025-04-10_21:18:02.661118_qEqk 2025-04-10_21:18:02.661140_gLma 2025-04-10_21:18:02.661146_CLMo 2025-04-10_21:18:02.661151_WqWh 2025-04-10_21:18:02.661155_KzhU 2025-04-10_21:18:02.661159_tkAp 2025-04-10_21:18:02.661163_BixF 2025-04-10_21:18:02.661166_CPOt 2025-04-10_21:18:02.661171_QIcZ

https://storage.googleapis.com/firebase-sdk-metric-reports/aKDayINja2/index.html

ehsannas

LGTM. Asked for one more check in the test.

firebase-firestore/src/androidTest/java/com/google/firebase/firestore/QueryTest.java

fix: remove null from != and not-in filters' result

a46885b

google-oss-bot added the size/M label Apr 9, 2025

Update CHANGELOG.md

e154065

milaGGL changed the title ~~fix: remove null value inclusion from != and not-in filter results~~ fix: remove null value inclusion from whereNotEqualTo and whereNotIn filter results Apr 10, 2025

ehsannas approved these changes Apr 10, 2025

View reviewed changes

firebase-firestore/src/androidTest/java/com/google/firebase/firestore/QueryTest.java Outdated Show resolved Hide resolved

This was referenced Apr 10, 2025

fix: remove null value inclusion from != and not-in filter results firebase/firebase-js-sdk#8915

Merged

fix: remove null value inclusion from isNotEqualTo and notIn filter results firebase/firebase-ios-sdk#14704

Merged

milaGGL added 3 commits April 10, 2025 16:43

add the "!= null" test case

ca214ea

Merge branch 'main' into mila/fix-incorrect-null-value-inclusion

ee841d8

use updated checkOnlineAndOfflineResultsMatch test helper

2fa8a24

milaGGL merged commit edcea54 into main Apr 11, 2025
37 of 43 checks passed

milaGGL deleted the mila/fix-incorrect-null-value-inclusion branch April 11, 2025 15:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: remove null value inclusion from `whereNotEqualTo` and `whereNotIn` filter results #6859

fix: remove null value inclusion from `whereNotEqualTo` and `whereNotIn` filter results #6859

milaGGL commented Apr 9, 2025 •

edited

Loading

github-actions bot commented Apr 9, 2025 •

edited

Loading

google-oss-bot commented Apr 9, 2025 •

edited

Loading

`firebase-firestore`

github-actions bot commented Apr 9, 2025 •

edited

Loading

google-oss-bot commented Apr 9, 2025 •

edited

Loading

`firebase-firestore`

google-oss-bot commented Apr 9, 2025 •

edited

Loading

`fire-fst`

`timeToInitialDisplay`

ehsannas left a comment

fix: remove null value inclusion from whereNotEqualTo and whereNotIn filter results #6859

fix: remove null value inclusion from whereNotEqualTo and whereNotIn filter results #6859

Conversation

milaGGL commented Apr 9, 2025 • edited Loading

github-actions bot commented Apr 9, 2025 • edited Loading

📝 PRs merging into main branch

google-oss-bot commented Apr 9, 2025 • edited Loading

Coverage Report 1

Affected Products

firebase-firestore

Test Logs

github-actions bot commented Apr 9, 2025 • edited Loading

Test Results

google-oss-bot commented Apr 9, 2025 • edited Loading

Size Report 1

Affected Products

firebase-firestore

Test Logs

google-oss-bot commented Apr 9, 2025 • edited Loading

Startup Time Report 1

Notes

Startup Times

fire-fst

timeToInitialDisplay

ehsannas left a comment

Choose a reason for hiding this comment

fix: remove null value inclusion from `whereNotEqualTo` and `whereNotIn` filter results #6859

fix: remove null value inclusion from `whereNotEqualTo` and `whereNotIn` filter results #6859

milaGGL commented Apr 9, 2025 •

edited

Loading

github-actions bot commented Apr 9, 2025 •

edited

Loading

google-oss-bot commented Apr 9, 2025 •

edited

Loading

Coverage Report ¹

`firebase-firestore`

github-actions bot commented Apr 9, 2025 •

edited

Loading

google-oss-bot commented Apr 9, 2025 •

edited

Loading

Size Report ¹

`firebase-firestore`

google-oss-bot commented Apr 9, 2025 •

edited

Loading

Startup Time Report ¹

`fire-fst`

`timeToInitialDisplay`