Skip to content

Add write permisison to VertexAI Response Checking task #6869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 12, 2025
Merged

Add write permisison to VertexAI Response Checking task #6869

merged 2 commits into from
Apr 12, 2025

Conversation

emilypgoogle
Copy link
Collaborator

The task began failing recently likely due to changes in global permissions, this updates the workflow to explicitly have write permissions to make comments.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 11, 2025 •
edited
Loading

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@emilypgoogle emilypgoogle reopened this Apr 11, 2025
@github-actions GitHub Actions
Copy link
Contributor

Vertex AI Mock Responses Check ⚠️

A newer major version of the mock responses for Vertex AI unit tests is available. update_responses.sh should be updated to clone the latest version of the responses: v10.0

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 11, 2025 •
edited
Loading

Test Results

 1 049 files  + 15   1 049 suites  +15   34m 52s ⏱️ +16s
 5 874 tests ±  0   5 851 ✅  -   1  22 💤 ±0  1 ❌ +1 
11 964 runs  +153  11 919 ✅ +152  44 💤 ±0  1 ❌ +1 

For more details on these failures, see this check.

Results for commit dcbb7c5. ± Comparison against base commit 4797eea.

♻️ This comment has been updated with latest results.

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

No changes between base commit (4797eea) and merge commit (d81532f).

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/jLfWofGGeT.html

@google-oss-bot
Copy link
Contributor

Coverage Report 1

Affected Products

  • firebase-config

    Overall coverage changed from ? (4797eea) to 84.30% (d81532f) by ?.

    34 individual files with coverage change

    FilenameBase (4797eea)Merge (d81532f)Diff
    AutoValue_ConfigUpdate.java?29.41%?
    Code.java?0.00%?
    ConfigAutoFetch.java?86.73%?
    ConfigCacheClient.java?93.33%?
    ConfigContainer.java?94.29%?
    ConfigFetchHandler.java?92.94%?
    ConfigFetchHttpClient.java?86.27%?
    ConfigGetParameterHandler.java?96.45%?
    ConfigRealtimeHandler.java?41.38%?
    ConfigRealtimeHttpClient.java?73.45%?
    ConfigSharedPrefsClient.java?87.50%?
    ConfigStorageClient.java?100.00%?
    ConfigUpdate.java?100.00%?
    ConfigUpdateListener.java?0.00%?
    ConfigUpdateListenerRegistration.java?0.00%?
    CustomSignals.java?100.00%?
    DefaultsXmlParser.java?0.00%?
    FirebaseRemoteConfig.java?89.76%?
    FirebaseRemoteConfigClientException.java?75.00%?
    FirebaseRemoteConfigException.java?95.65%?
    FirebaseRemoteConfigFetchThrottledException.java?100.00%?
    FirebaseRemoteConfigInfo.java?0.00%?
    FirebaseRemoteConfigInfoImpl.java?100.00%?
    FirebaseRemoteConfigServerException.java?68.42%?
    FirebaseRemoteConfigSettings.java?61.54%?
    FirebaseRemoteConfigValue.java?0.00%?
    FirebaseRemoteConfigValueImpl.java?84.62%?
    Personalization.java?91.43%?
    RemoteConfig.kt?31.58%?
    RemoteConfigComponent.java?90.70%?
    RemoteConfigConstants.java?0.00%?
    RemoteConfigRegistrar.java?100.00%?
    RolloutsStateFactory.java?95.24%?
    RolloutsStateSubscriptionsHandler.java?100.00%?

  • firebase-database

    Overall coverage changed from 50.16% (4797eea) to 50.21% (d81532f) by +0.04%.

    FilenameBase (4797eea)Merge (d81532f)Diff
    ChildChangeAccumulator.java83.33%96.67%+13.33%

  • firebase-firestore

    Overall coverage changed from 45.78% (4797eea) to 45.78% (d81532f) by -0.00%.

    FilenameBase (4797eea)Merge (d81532f)Diff
    PatchMutation.java100.00%98.39%-1.61%

  • firebase-messaging

    Overall coverage changed from 84.13% (4797eea) to 84.02% (d81532f) by -0.11%.

    FilenameBase (4797eea)Merge (d81532f)Diff
    Metadata.java41.27%36.51%-4.76%

  • firebase-sessions

    Overall coverage changed from 66.56% (4797eea) to 66.67% (d81532f) by +0.11%.

    FilenameBase (4797eea)Merge (d81532f)Diff
    RemoteSettings.kt87.32%88.73%+1.41%

  • firebase-storage

    Overall coverage changed from 84.33% (4797eea) to 84.00% (d81532f) by -0.33%.

    FilenameBase (4797eea)Merge (d81532f)Diff
    StorageException.java69.09%65.45%-3.64%
    StorageTask.java83.99%83.38%-0.60%
    UploadTask.java83.17%81.85%-1.32%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/79pH1kcG0R.html

@google-oss-bot
Copy link
Contributor

Startup Time Report 1

The report is too large (122,573 chars) to be displayed on GitHub. Please check this report on GCS.

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/3Q2Zek2S9A/index.html

@rlazo rlazo merged commit 9293eec into main Apr 12, 2025
415 of 421 checks passed
@rlazo rlazo deleted the ep/check-vertexai-responses-fix branch April 12, 2025 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rlazo rlazo rlazo approved these changes

Assignees

@rlazo rlazo

Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emilypgoogle @google-oss-bot @rlazo