Skip to content

Point workflows at new python requirements file #1035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 19, 2022

Conversation

DellaBitta
Copy link
Contributor

Description

Provide details of the change, and generalize the change in the PR title above.

Fixes to the Check Secure and Packaging workflows to point them to the. new python requirements file gha/scripts/requirements.txt.


Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Packaging Worfklow


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@DellaBitta DellaBitta changed the title point workflows at new python requirements file Point workflows at new python requirements file Jul 19, 2022
@DellaBitta DellaBitta requested a review from AlmostMatt July 19, 2022 13:01
@DellaBitta DellaBitta marked this pull request as ready for review July 19, 2022 13:01
@DellaBitta DellaBitta added the skip-release-notes Skip release notes check label Jul 19, 2022
@DellaBitta DellaBitta merged commit 4016745 into main Jul 19, 2022
@DellaBitta DellaBitta deleted the bugfix/python_requirements branch July 19, 2022 14:25
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label Jul 19, 2022
@github-actions
Copy link

github-actions bot commented Jul 19, 2022

❌  Integration test FAILED

Requested by @DellaBitta on commit 4016745
Last updated: Tue Jul 19 11:19 PDT 2022
View integration test log & download artifacts

Failures Configs
missing_log [TEST] [ERROR] [Android] [1/3 os: windows] [1/2 android_device: emulator_target]
firestore [TEST] [ERROR] [Android] [1/3 os: ubuntu] [1/2 android_device: android_target]
[TEST] [FLAKINESS] [Android] [1/3 os: macos] [1/2 android_device: android_target]
(1 failed tests)  ServerTimestampTest.TestServerTimestampsUsesPreviousValueFromLocalMutation
[TEST] [FLAKINESS] [iOS] [macos] [1/2 ios_device: ios_target]
(1 failed tests)  CRASH/TIMEOUT

Add flaky tests to go/fpl-cpp-flake-tracker

@AlmostMatt
Copy link
Contributor

FYI - I think this will change back to "python_requirements" soon, it was a side effect of rolling back a change that will be roll-forwarded soon with a fix
https://github.com/firebase/firebase-cpp-sdk/pull/1033/files

@dconeybe
Copy link
Contributor

@AlmostMatt I left a comment on the roll-forward PR, #1033, to make sure to roll forward this change too.

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Jul 19, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jul 19, 2022
@firebase firebase locked and limited conversation to collaborators Aug 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
skip-release-notes Skip release notes check tests: failed This PR's integration tests failed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants