Skip to content

[Bugfix] Windows openssl build #1033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 19, 2022
Merged

[Bugfix] Windows openssl build #1033

merged 5 commits into from
Jul 19, 2022

Conversation

sunmou99
Copy link
Contributor

@sunmou99 sunmou99 commented Jul 18, 2022 •
edited
Loading

@sunmou99 sunmou99 added tests-requested: quick Trigger a quick set of integration tests. skip-release-notes Skip release notes check labels Jul 18, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Jul 18, 2022
@github-actions
Copy link

github-actions bot commented Jul 18, 2022 •
edited
Loading

❌  Integration test FAILED

Requested by @sunmou99 on commit 584564f
Last updated: Tue Jul 19 15:49 PDT 2022
View integration test log & download artifacts

Failures Configs
missing_log [TEST] [ERROR] [Android] [2/3 os: windows ubuntu] [1/2 android_device: emulator_target]
database [TEST] [ERROR] [Windows] [x64] [openssl]
firestore [TEST] [FLAKINESS] [Android] [1/3 os: macos] [1/2 android_device: android_target]
(1 failed tests)  CRASH/TIMEOUT
gma [TEST] [FLAKINESS] [iOS] [macos] [1/2 ios_device: ios_target]
(1 failed tests)  FirebaseGmaTest.TestRewardedAdStress
storage [TEST] [FAILURE] [MacOS] [x64] [openssl]
(1 failed tests)  FirebaseStorageTest.TestGetFileWithMaxRetryDuration

Add flaky tests to go/fpl-cpp-flake-tracker

@sunmou99 sunmou99 added the tests-requested: quick Trigger a quick set of integration tests. label Jul 18, 2022
@github-actions github-actions bot removed the tests-requested: quick Trigger a quick set of integration tests. label Jul 18, 2022
@sunmou99 sunmou99 changed the title [Bugfix] Windows openssl build missing openssl tool [Bugfix] Windows openssl build Jul 19, 2022
@sunmou99 sunmou99 requested a review from AlmostMatt July 19, 2022 01:01
@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Jul 19, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jul 19, 2022
@AlmostMatt
Copy link
Contributor

desktop-windows-latests-x64-openssl test passed, which seems like a pretty good sign.

There is an integration test failure for android-windows-latest-android_target-gameloop. Does the failure look like a flake to you? It mentions errors, but I don't see any specific error messages in the summary.

I'll trigger re-running the failure in the meantime

AlmostMatt
AlmostMatt reviewed Jul 19, 2022
View reviewed changes
scripts/gha/install_prereqs_desktop.py
@@ -54,14 +54,16 @@ def main():
# brew install go
utils.run_command(['brew', 'install', 'go'])

# Install openssl on linux/mac if its not installed already
if args.ssl == 'openssl' and not utils.is_command_installed('openssl'):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there some reason to remove this condition?
" and not utils.is_command_installed('openssl') "

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems openssl already exists on windows runner. With this condition, the cmd won't run.

@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Jul 19, 2022
@dconeybe
Copy link
Contributor

NOTE: Make sure to include rolling forward #1035 in this PR

AlmostMatt
AlmostMatt requested changes Jul 19, 2022
View reviewed changes
Copy link
Contributor

@AlmostMatt AlmostMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Integration tests passed.
As Denver mentioned, please update the changes of #1035 as part of this change as well since this change renames requirements to python_requirements.

@dconeybe dconeybe mentioned this pull request Jul 19, 2022
Merged
3 tasks
@sunmou99 sunmou99 requested a review from AlmostMatt July 19, 2022 17:28
@sunmou99 sunmou99 removed the tests: failed This PR's integration tests failed. label Jul 19, 2022
@sunmou99 sunmou99 enabled auto-merge (squash) July 19, 2022 17:40
@sunmou99 sunmou99 merged commit 584564f into main Jul 19, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. tests: failed This PR's integration tests failed. and removed tests: succeeded This PR's integration tests succeeded. labels Jul 19, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jul 19, 2022
@sunmou99 sunmou99 deleted the revert-1029-rollback-pr-1010 branch August 3, 2022 16:55
@firebase firebase locked and limited conversation to collaborators Aug 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AlmostMatt AlmostMatt AlmostMatt approved these changes

Assignees
No one assigned
Labels
skip-release-notes Skip release notes check tests: failed This PR's integration tests failed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sunmou99 @AlmostMatt @dconeybe