Skip to content

Increase Maven Connection Stability in GHA Android Builds #818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 21, 2022

Conversation

DellaBitta
Copy link
Contributor

@DellaBitta DellaBitta commented Jan 20, 2022

Description

Provide details of the change, and generalize the change in the PR title above.

Attempt to reduce Android CI build flake caused by network connection timeouts to the Maven repo.

Following instructions from the GHA Github Repo Issues forum. The fix seems to be very popular with 34 other closed issues referencing it.


Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Integration Test CI
Packaging CI -> Integration Test CI


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@DellaBitta DellaBitta added the skip-release-notes Skip release notes check label Jan 20, 2022
@DellaBitta DellaBitta marked this pull request as ready for review January 20, 2022 21:49
@DellaBitta DellaBitta merged commit 3adf913 into main Jan 21, 2022
@DellaBitta DellaBitta deleted the bugfix/maven_timeout branch January 21, 2022 03:11
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label Jan 21, 2022
@github-actions
Copy link

github-actions bot commented Jan 21, 2022

Integration test with FLAKINESS (succeeded after retry)

Requested by @DellaBitta on commit 3adf913
Last updated: Thu Jan 20 21:43 PST 2022
View integration test log & download artifacts

Failures Configs
firestore [TEST] [FLAKINESS] [Android] [1/3 os: macos] [1/2 android_device: android_target]
(1 failed tests)  CRASH/TIMEOUT

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Jan 21, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Jan 21, 2022
DellaBitta added a commit that referenced this pull request Jan 21, 2022
* Add a delay to the Analytics test app. (#788)

* Add a delay when the Analytics test finishes.

* In the test report, if test failed on all devices. Mark [All x test devices]  (#784)

* Disable -Wnullability-completeness on iOS and macOS. (#782)

* Disable -Wnullability-completeness on iOS and macOS.

* Remove NDK if the cache hit failed.

* Update public documentation for C++ FCM SDK. (#789)

As of Firebase C++ SDK 7.1.0, we started using JobIntentService for scheduling jobs. This change requires a few additional modifications to AndroidManifest.xml and a new way of starting a background service.

These changes were done to the old repository, and need to be brought to GitHub.

* Split mutex.h into .h and .cc files (#751)

* future.h: Fix minor typo in the docs for FutureBase (#794)

* Move mutex.h header to public internal (#792)

* Delete app/src/mutex.h and adjust includes to app/src/include/firebase/internal/mutex.h (#795)

* future.h: replace std::mutex with firebase::Mutex (#798)

* Change setup-gcloud to use @v0 instead of @master as per their readme. (#802)

* fix Log NoneType Error (#807)

* Update Android dependencies - Thu Jan 06 2022 (#809)

[Triggered](https://github.com/firebase/firebase-android-sdk/actions/runs/1665092765) by [firebase-android-sdk Jan 06 release](firebase/firebase-android-sdk@22ee484).

  ### Android

- com.google.android.gms.play_services_base → 18.0.1
- com.google.firebase.firebase_analytics → 20.0.2

> Created by [Update Android and iOS dependencies workflow](https://github.com/firebase/firebase-cpp-sdk/actions/runs/1665095030).

Co-authored-by: firebase-workflow-trigger-bot <[email protected]>

* add -DNOMINMAX to both WIN32 and WIN64 (#810)

* add -DNOMINMAX to both WIN32 and WIN64

* test

* test

* test

* test

* remove helper print

* format code

Co-authored-by: Cynthia Jiang <[email protected]>

* In the Test Summary Report, add "x/y" which means "x" out of "y" configs has errors. (#812)

* mutex header include path

* maven connectivity parameters (#818)

CI scripts invoke gradle in a way to circumvent Azure-to-Maven connection pool timeout issues.

Co-authored-by: Jon Simantov <[email protected]>
Co-authored-by: Mou Sun <[email protected]>
Co-authored-by: a-maurice <[email protected]>
Co-authored-by: Denver Coneybeare <[email protected]>
Co-authored-by: firebase-workflow-trigger[bot] <80733318+firebase-workflow-trigger[bot]@users.noreply.github.com>
Co-authored-by: firebase-workflow-trigger-bot <[email protected]>
Co-authored-by: Cynthia J <[email protected]>
Co-authored-by: Cynthia Jiang <[email protected]>
@firebase firebase locked and limited conversation to collaborators Feb 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
skip-release-notes Skip release notes check tests: succeeded This PR's integration tests succeeded.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants