-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Upgrade grpc and abseil for SPM and cocoapods #9486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Generated by 🚫 Danger |
Size Report 1Affected ProductsTest Logs |
Coverage Report 1Affected Products
Test Logs |
abseil build break to be fixed via firebase/abseil-cpp-SwiftPM#9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Why aren't the abseil versions consistent between CocoaPods and SPM?
- Why is the CocoaPods abseil version locked to a patch release but SPM enables patch updates?
- Why do we allow patch updates for abseil but not gRPC
- Is the CI build warning in abseil fixable:
-
- WARN | xcodebuild: /Users/runner/Library/Developer/Xcode/DerivedData/App-ffzsphyzsoubipeuqfnlcfzcgour/Build/Products/Release-iphonesimulator/abseil/absl.framework/Headers/strings/str_split.h:517:7: warning: Forwarding reference passed to std::move(), which may unexpectedly cause lvalues to be moved; use std::forward() instead [bugprone-move-forwarding-reference]
- WARN | xcodebuild: /Users/runner/Library/Developer/Xcode/DerivedData/App-ffzsphyzsoubipeuqfnlcfzcgour/Build/Products/Release-iphonesimulator/abseil/absl.framework/Headers/strings/str_split.h:542:7: warning: Forwarding reference passed to std::move(), which may unexpectedly cause lvalues to be moved; use std::forward() instead [bugprone-move-forwarding-reference]
Abseil on cocoapods is behind, I am using the latest I can use. @dennycd can you help?
I am not sure why abseil is fixed on version. The history is lost..I am guess we have been bitten before by absl. I am enabling it for now...let's see what happens. gRPC being fixed is a mistake.
Will check. |
looks like abseil-cpp-SwiftPM's tag (0.20220203.0 and up) are indeed using the same abseil version as latest cocoapod (20211102.0), just that the tag names from abseil-cpp-SwiftPM doesn't exactly match abseil's release tags. We can either keep the current tag scheme for now, or re-tag abseil-cpp-SwiftPM to match that from cocoapod (e.g. 0.20211102.0). Hopefully once we resolve abseil SPM & Cocoapod dependency w/ abseil team, we can start using a consistent release tag from the same repo |
This PR also includes grpc/grpc#27300, which resolves firebase/quickstart-ios#1099. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM on green
No description provided.