Upgrade grpc and abseil for SPM and cocoapods #9486
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulb777
reviewed
Mar 21, 2022
Generated by 🚫 Danger |
Size Report 1Affected ProductsTest Logs |
Coverage Report 1Affected Products
Test Logs |
|
abseil build break to be fixed via firebase/abseil-cpp-SwiftPM#9 |
paulb777
reviewed
Mar 23, 2022
There was a problem hiding this comment.
- Why aren't the abseil versions consistent between CocoaPods and SPM?
- Why is the CocoaPods abseil version locked to a patch release but SPM enables patch updates?
- Why do we allow patch updates for abseil but not gRPC
- Is the CI build warning in abseil fixable:
-
- WARN | xcodebuild: /Users/runner/Library/Developer/Xcode/DerivedData/App-ffzsphyzsoubipeuqfnlcfzcgour/Build/Products/Release-iphonesimulator/abseil/absl.framework/Headers/strings/str_split.h:517:7: warning: Forwarding reference passed to std::move(), which may unexpectedly cause lvalues to be moved; use std::forward() instead [bugprone-move-forwarding-reference]- WARN | xcodebuild: /Users/runner/Library/Developer/Xcode/DerivedData/App-ffzsphyzsoubipeuqfnlcfzcgour/Build/Products/Release-iphonesimulator/abseil/absl.framework/Headers/strings/str_split.h:542:7: warning: Forwarding reference passed to std::move(), which may unexpectedly cause lvalues to be moved; use std::forward() instead [bugprone-move-forwarding-reference]
Abseil on cocoapods is behind, I am using the latest I can use. @dennycd can you help?
I am not sure why abseil is fixed on version. The history is lost..I am guess we have been bitten before by absl. I am enabling it for now...let's see what happens. gRPC being fixed is a mistake.
Will check. |
looks like abseil-cpp-SwiftPM's tag (0.20220203.0 and up) are indeed using the same abseil version as latest cocoapod (20211102.0), just that the tag names from abseil-cpp-SwiftPM doesn't exactly match abseil's release tags. We can either keep the current tag scheme for now, or re-tag abseil-cpp-SwiftPM to match that from cocoapod (e.g. 0.20211102.0). Hopefully once we resolve abseil SPM & Cocoapod dependency w/ abseil team, we can start using a consistent release tag from the same repo |
|
This PR also includes grpc/grpc#27300, which resolves firebase/quickstart-ios#1099. |
wu-hui
added a commit
that referenced
this pull request
Mar 25, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.