Fix abseil forward ref warning for StrSplit #9539
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennycd
force-pushed
the
abseil_warning_fix
branch
17 times, most recently
from
1cba3a9 to
6f7e251
Compare
dennycd
force-pushed
the
abseil_warning_fix
branch
from
6f7e251 to
2f1f19a
Compare
|
I believe this has been resolved. Closing the PR. Please reopen if still needed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patching StrSplit usage for bugprone-move-forwarding-reference warning as seem from #9486. StrSplit requires a forwarding reference (rvalue ref inferred from a template param) to be passed into its first parameter, and we are currently passing a lvalue ref instead.