-
Notifications
You must be signed in to change notification settings - Fork 937
fix: Auth env detection for capacitor #6236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 0de2c76 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). For more information, open the CLA check for this pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR. Have you verified this works in a capacitor project?
@sam-gc it's a solution was proposed and test in the issue #5020 (comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again!
@avolkovi @lisajian @yuchenshi, i know you have ton of work but please take 5 min to review it. |
Hi @riderx, it looks like the formatting check failed. Please run |
@sam-gc i did |
@riderx yeah it appears that file is updated. I'm rerunning the status checks |
@sam-gc ok i fixed with the feedback of the CI |
@sam-gc the test have failed again and i fixed again, i still don't know why i cannot reproduce in local, sorry about that. |
Okay it's looking good, @riderx would you mind adding a changeset before mergning (see the comment up above for instructions). |
Of course @sam-gc i will :) |
@sam-gc done, i hope i understand it well :) |
Looks great, thanks again! Once the workflow run completes please feel free to merge when the button is enabled |
@sam-gc one CI is still failing it says the token is missing, so i can't merge myself |
Odd, I don't know why it's blocking you but I'll go ahead and merge. |
No change to current codebase is just addition to make the SDK work as expected in capacitor app, like in Cordova app