Skip to content

fix: Auth env detection for capacitor #6236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 23, 2022
Merged

fix: Auth env detection for capacitor #6236

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
6de6a91
fix: for capacitor
riderx May 5, 2022
3f53385
Update platform.ts
riderx May 9, 2022
076093b
Update platform.ts
riderx May 9, 2022
f3acf08
fix: lint
riderx May 20, 2022
2542c4e
fix: lint
riderx May 20, 2022
c570ec4
fix: lint issue in CI
riderx May 20, 2022
0de2c76
add changeset
riderx May 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/polite-fireants-mate.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@firebase/auth-compat': patch
---

Fix auth scheme reconition in capacitor env
4 changes: 3 additions & 1 deletion packages/auth-compat/src/platform.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,9 @@ function _isHttpOrHttps(): boolean {
*/
export function _isAndroidOrIosCordovaScheme(ua: string = getUA()): boolean {
return !!(
(_getCurrentScheme() === 'file:' || _getCurrentScheme() === 'ionic:') &&
(_getCurrentScheme() === 'file:' ||
_getCurrentScheme() === 'ionic:' ||
_getCurrentScheme() === 'capacitor:') &&
ua.toLowerCase().match(/iphone|ipad|ipod|android/)
);
}
Expand Down