-
Notifications
You must be signed in to change notification settings - Fork 1k
Functions breakpoint debugging #1798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
API was approved, made changes requested by council, now time for code review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at some of the readability/CLI stuff mostly - I'll leave the logic of emulators to more knowledgable folks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly LGTM with major (blocking) comments regarding WorkQueue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changelog please 😁
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bkendall @yuchenshi what would you expect the behavior to be if you edit code while debugging? We currently hot reload code but obviously that will require restarting the process which means killing your debugger connection. Does that seem OK?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except the major comment about Zalgo on the test cases.
Can I do this with |
nice work! |
Description
Fixes #1360
This PR enables multi-function breakpoint debugging sessions. The compromise is that when you want to enable this you have to move to a model where all executions share a single
RuntimeWorker
and requests are handled sequentially.TODO:
Scenarios Tested
Functions
VSCode launch.json
Sample Commands