Skip to content

Create Unity GHA and apply to all the workflows #512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 48 commits into from
Nov 2, 2022
Merged

Create Unity GHA and apply to all the workflows #512

merged 48 commits into from
Nov 2, 2022

Conversation

sunmou99
Copy link
Contributor

@sunmou99 sunmou99 commented Nov 2, 2022 •
edited
Loading

Description

Replace all the Unity logic in workflows with GHA.

Testing

Describe how you've tested these changes.
Package workflow: https://github.com/firebase/firebase-unity-sdk/actions/runs/3374812234
Test workflow: see comment below

Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

@sunmou99 sunmou99 changed the title Unity gha Create Unity GHA and apply to all the workflows Nov 2, 2022
@sunmou99 sunmou99 marked this pull request as ready for review November 2, 2022 04:22
@sunmou99 sunmou99 added the tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). label Nov 2, 2022
@sunmou99 sunmou99 self-assigned this Nov 2, 2022
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: full Trigger a FULL set of integration tests (uses expanded test matrix). labels Nov 2, 2022
@github-actions
Copy link

github-actions bot commented Nov 2, 2022 •
edited
Loading

❌  Integration test FAILED

Requested by @firebase-workflow-trigger[bot] on commit e90453b
Last updated: Wed Nov 2 01:44 PDT 2022
View integration test log & download artifacts

Failures Configs
analytics [TEST] [ERROR] [2020] [1/2 Build OS(s): windows] [1/6 Platform(s): macOS] [1/3 Test Device(s): github_runner]
crashlytics [BUILD] [ERROR] [2020] [1/2 Build OS(s): windows] [1/3 Platform(s): Android] [1/3 Test Device(s): NA]
[TEST] [ERROR] [2020] [1/2 Build OS(s): windows] [1/6 Platform(s): Playmode] [1/3 Test Device(s): github_runner]
functions [TEST] [ERROR] [2020] [1/2 Build OS(s): windows] [1/6 Platform(s): Windows] [1/3 Test Device(s): github_runner]
messaging [BUILD] [ERROR] [2020] [1/2 Build OS(s): windows] [1/3 Platform(s): Android] [1/3 Test Device(s): NA]
[TEST] [ERROR] [2020] [All 2 Build OS(s)] [2/6 Platform(s): Playmode iOS] [2/3 Test Device(s): ios_target github_runner]
storage [TEST] [ERROR] [2020] [1/2 Build OS(s): macos] [2/6 Platform(s): Android iOS] [All 2 FTL Devices]
[TEST] [FAILURE] [2020] [All 2 Build OS(s)] [3/6 Platform(s): macOS Android Windows] [2/3 Test Device(s): android_target github_runner]

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Nov 2, 2022
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Nov 2, 2022
@sunmou99 sunmou99 requested a review from cynthiajoan November 2, 2022 16:58
cynthiajoan
cynthiajoan reviewed Nov 2, 2022
View reviewed changes
.github/workflows/build_linux.yml Outdated

- name: Setup Unity path
- name: Setup Env
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: seems it's only setup swig related environment, so let's be a bit more specific, set the name to Setup Swig Env

cynthiajoan
cynthiajoan reviewed Nov 2, 2022
View reviewed changes
.github/workflows/build_macos.yml Outdated

- name: Setup Unity path
- name: Setup Env
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

cynthiajoan
cynthiajoan reviewed Nov 2, 2022
View reviewed changes
.github/workflows/build_windows.yml Outdated

- name: Setup Unity path
- name: Setup Env
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

@sunmou99 sunmou99 merged commit 9b3d1f0 into main Nov 2, 2022
@sunmou99 sunmou99 deleted the unity-gha branch November 4, 2022 19:15
@firebase firebase locked and limited conversation to collaborators Dec 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cynthiajoan cynthiajoan cynthiajoan approved these changes

Assignees

@sunmou99 sunmou99

Labels
tests: failed This PR's integration tests failed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sunmou99 @cynthiajoan