-
Notifications
You must be signed in to change notification settings - Fork 46
Create Unity GHA and apply to all the workflows #512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from 47 commits
Commits
Show all changes
48 commits
Select commit
Hold shift + click to select a range
b36d6c8
merge unity installation & activation
sunmou99 065b4da
merge unity installation & activation
sunmou99 37c6721
add platform installation info
sunmou99 cb08667
uses unity github action
sunmou99 d918060
update gha path
sunmou99 a433708
update gha
sunmou99 4b4119e
update gha
sunmou99 3ea2eb1
update gha
sunmou99 8e32c87
update gha
sunmou99 6244f81
update gha
sunmou99 1be2fee
update gha
sunmou99 c69efc1
update gha
sunmou99 7f73b74
Return Unity license
sunmou99 3850349
update check
sunmou99 3282f68
update check
sunmou99 5d5f727
readme
sunmou99 5ab3cd2
merge main
sunmou99 6280134
test latest u3d version
sunmou99 7d23b46
test latest u3d version
sunmou99 56b9f3b
test env
sunmou99 4639867
test env
sunmou99 0c2211f
shell: bash
sunmou99 597e58a
test
sunmou99 563288f
test 1.3.0
sunmou99 53de1cf
test 1.2.3
sunmou99 bd23ce7
test ruby 2.6.10
sunmou99 daee4dc
move unity gha path
sunmou99 acf2db8
test playmode
sunmou99 32b4560
build android
sunmou99 0d6182d
update u3d version
sunmou99 cc0e4d8
use unity gha
sunmou99 b394b6e
decouple unity installation
sunmou99 0577f32
remove unity setting from print_matrix_CONFIG
sunmou99 00fbe69
fix unity path
sunmou99 e4cacc5
add unity_path to the env
sunmou99 0182baf
remove some env
sunmou99 ba59c81
update return value
sunmou99 c2c7642
add tvos to unity gha
sunmou99 9162aed
test output
sunmou99 afb24fe
fix output
sunmou99 7362691
remove debug code
sunmou99 e1c8ee1
update android ndk patch
sunmou99 951b76d
update unity gha output
sunmou99 bbe948e
update unity gha output
sunmou99 3f4badd
remove env
sunmou99 4b45c50
active unity license for playmode
sunmou99 e90453b
add read me
sunmou99 12d50fe
update based on comments
sunmou99 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -41,14 +41,7 @@ jobs: | |
runs-on: macos-latest | ||
strategy: | ||
fail-fast: false | ||
|
||
env: | ||
# LC_ALL, LANG and U3D_PASSWORD are needed for U3D. | ||
LC_ALL: en_US.UTF-8 | ||
LANG: en_US.UTF-8 | ||
U3D_PASSWORD: "" | ||
# Disable checking for U3D updates, since it is buggy | ||
U3D_SKIP_UPDATE_CHECK: 1 | ||
|
||
steps: | ||
- uses: actions/checkout@v3 | ||
with: | ||
|
@@ -68,14 +61,6 @@ jobs: | |
with: | ||
ruby-version: 3.0.2 | ||
|
||
- name: Install Unity installer (U3D) | ||
uses: nick-invision/retry@v2 | ||
with: | ||
timeout_minutes: 10 | ||
max_attempts: 3 | ||
shell: bash | ||
command: gem install u3d -v 1.2.3 | ||
|
||
- name: Setup python | ||
uses: actions/setup-python@v4 | ||
with: | ||
|
@@ -104,19 +89,15 @@ jobs: | |
# brew won't overwrite MacOS system default OpenSSL, so force it here. | ||
echo "OPENSSL_ROOT_DIR=$(brew --prefix openssl --installed)" >> $GITHUB_ENV | ||
|
||
- name: Install Unity | ||
uses: nick-invision/retry@v2 | ||
- id: unity_setup | ||
uses: firebase/firebase-unity-sdk/gha/unity@unity-gha | ||
with: | ||
timeout_minutes: 15 | ||
max_attempts: 3 | ||
shell: bash | ||
command: | | ||
python scripts/gha/unity_installer.py --install --platforms ${{ inputs.unity_platform_name }} --version ${{ inputs.unity_version }} | ||
version: ${{ inputs.unity_version }} | ||
platforms: ${{ inputs.unity_platform_name }} | ||
|
||
- name: Setup Unity path | ||
- name: Setup Env | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same |
||
shell: bash | ||
run: | | ||
echo "UNITY_ROOT_DIR=$( python scripts/gha/print_matrix_configuration.py -u ${{ inputs.unity_version }} -k unity_path )" >> $GITHUB_ENV | ||
echo "$(swig -swiglib)" >> $GITHUB_PATH | ||
swig -swiglib | ||
echo "SWIG_DIR=$(swig -swiglib)" >> $GITHUB_ENV | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -41,14 +41,7 @@ jobs: | |
runs-on: windows-2019 | ||
strategy: | ||
fail-fast: false | ||
|
||
env: | ||
# LC_ALL, LANG and U3D_PASSWORD are needed for U3D. | ||
LC_ALL: en_US.UTF-8 | ||
LANG: en_US.UTF-8 | ||
U3D_PASSWORD: "" | ||
# Disable checking for U3D updates, since it is buggy | ||
U3D_SKIP_UPDATE_CHECK: 1 | ||
|
||
steps: | ||
- uses: actions/checkout@v3 | ||
with: | ||
|
@@ -71,14 +64,6 @@ jobs: | |
with: | ||
ruby-version: 3.0.2 | ||
|
||
- name: Install Unity installer (U3D) | ||
uses: nick-invision/retry@v2 | ||
with: | ||
timeout_minutes: 10 | ||
max_attempts: 3 | ||
shell: bash | ||
command: gem install u3d -v 1.2.3 | ||
|
||
- name: Setup python | ||
uses: actions/setup-python@v4 | ||
with: | ||
|
@@ -104,19 +89,15 @@ jobs: | |
run: | | ||
choco install openssl -r | ||
|
||
- name: Install Unity | ||
uses: nick-invision/retry@v2 | ||
- id: unity_setup | ||
uses: firebase/firebase-unity-sdk/gha/unity@unity-gha | ||
with: | ||
timeout_minutes: 15 | ||
max_attempts: 3 | ||
shell: bash | ||
command: | | ||
python scripts/gha/unity_installer.py --install --platforms ${{ inputs.unity_platform_name }} --version ${{ inputs.unity_version }} | ||
version: ${{ inputs.unity_version }} | ||
platforms: ${{ inputs.unity_platform_name }} | ||
|
||
- name: Setup Unity path | ||
- name: Setup Env | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same |
||
shell: bash | ||
run: | | ||
echo "UNITY_ROOT_DIR=$( python scripts/gha/print_matrix_configuration.py -u ${{inputs.unity_version}} -k unity_path )" >> $GITHUB_ENV | ||
echo "$(swig -swiglib)" >> $GITHUB_PATH | ||
swig -swiglib | ||
echo "SWIG_DIR=$(swig -swiglib)" >> $GITHUB_ENV | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: seems it's only setup swig related environment, so let's be a bit more specific, set the name to Setup Swig Env