Unit tests for the settings channel #146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
bwikbs
commented
Jul 15, 2021
bwikbs
commented
- TC is taken from the window port
- Divide the setting channel into two part (common / platform)
- Change the interface of setting channel
Signed-off-by: MuHong Byun <[email protected]>
bwikbs
force-pushed
the
unittest_settingchannel
branch
from
5e7891d to
fee84ca
Compare
Signed-off-by: MuHong Byun <[email protected]>
bwikbs
force-pushed
the
unittest_settingchannel
branch
from
b81ebfd to
fd3997d
Compare
This reverts commit fd3997d.
* Update flutter_tizen_engine_unittest (localization) * Rename file : settings_channel_device.cc -> settings_channel_tizen.cc settings_channel_stub.cc -> settings_channel_linux.cc Signed-off-by: MuHong Byun <[email protected]>
swift-kim
reviewed
Jul 19, 2021
Signed-off-by: MuHong Byun <[email protected]>
swift-kim
changed the title
swift-kim
reviewed
Jul 19, 2021
bwikbs
force-pushed
the
unittest_settingchannel
branch
from
d28dac6 to
97ac287
Compare
swift-kim
approved these changes
Jul 19, 2021
swift-kim
reviewed
Jul 19, 2021
Comment on lines
5
to
9
| #include "flutter/shell/platform/embedder/test_utils/proc_table_replacement.h" | ||
| #include "flutter/shell/platform/tizen/flutter_tizen_engine.h" | ||
| #include "flutter/shell/platform/tizen/testing/engine_modifier.h" |
There was a problem hiding this comment.
Suggested change
| #include "flutter/shell/platform/embedder/test_utils/proc_table_replacement.h" | |
| #include "flutter/shell/platform/tizen/flutter_tizen_engine.h" | |
| #include "flutter/shell/platform/tizen/testing/engine_modifier.h" | |
| #include "flutter_tizen_engine.h" | |
| #include "flutter/shell/platform/embedder/test_utils/proc_table_replacement.h" | |
| #include "flutter/shell/platform/tizen/testing/engine_modifier.h" |
Signed-off-by: MuHong Byun <[email protected]>
bwikbs
force-pushed
the
unittest_settingchannel
branch
from
97ac287 to
22c726c
Compare
swift-kim
reviewed
Jul 19, 2021
Comment on lines
+7
to
+8
| #include <chrono> | ||
| #include <ctime> |
There was a problem hiding this comment.
Suggested change
| #include <chrono> | |
| #include <ctime> | |
| #include <locale> |
Comment on lines
+5
to
+6
| #include <system/system_settings.h> | ||
| #include "settings_channel.h" |
There was a problem hiding this comment.
Suggested change
| #include <system/system_settings.h> | |
| #include "settings_channel.h" | |
| #include "settings_channel.h" | |
| #include <system/system_settings.h> |
|
@bbrto21 😕😕😕 |
😢 |
|
flutter_tizen_engine_unittest.cc #include <gtest/gtest.h>
#include "flutter/shell/platform/tizen/flutter_tizen_engine.h"
#include "flutter/shell/platform/embedder/test_utils/proc_table_replacement.h"
#include "flutter/shell/platform/tizen/testing/engine_modifier.h"flutter_tizen_texture_registrar_unittests.cc #include <gtest/gtest.h>
#include <iostream>
#include "flutter/shell/platform/tizen/flutter_tizen_texture_registrar.h"
#include "flutter/shell/platform/embedder/test_utils/proc_table_replacement.h"
#include "flutter/shell/platform/tizen/flutter_tizen_engine.h"
#include "flutter/shell/platform/tizen/testing/engine_modifier.h"settings_channel_tizen.cc #include "settings_channel.h"
#include <system/system_settings.h>@swift-kim @bbrto21 How about this? |
|
This is final version! #include "flutter/shell/platform/tizen/flutter_tizen_engine.h"
#include "flutter/shell/platform/embedder/test_utils/proc_table_replacement.h"
#include "flutter/shell/platform/tizen/testing/engine_modifier.h"
#include "gtest/gtest.h"flutter_tizen_texture_registrar_unittests.cc #include "flutter/shell/platform/tizen/flutter_tizen_texture_registrar.h"
#include <iostream>
#include "flutter/shell/platform/embedder/test_utils/proc_table_replacement.h"
#include "flutter/shell/platform/tizen/flutter_tizen_engine.h"
#include "flutter/shell/platform/tizen/testing/engine_modifier.h"
#include "gtest/gtest.h"settings_channel_tizen.cc #include "settings_channel.h"
#include <system/system_settings.h> |
|
@swift-kim Sorry! I just saw approval and missed the conversation. |
bbrto21
reviewed
Jul 19, 2021
| engine_->RunEngine(); | ||
|
|
||
| EXPECT_TRUE(run_called); | ||
| EXPECT_TRUE(update_locales_called); |
There was a problem hiding this comment.
It will pass at #147. For the next PR, only TC was added intentionally.
swift-kim
pushed a commit
that referenced
this pull request
Sep 27, 2021
* Add setting channel unit test Signed-off-by: MuHong Byun <[email protected]> * Add localization_channel unit test Signed-off-by: MuHong Byun <[email protected]> * Revert "Add localization_channel unit test" This reverts commit fd3997d. * Update minor things: * Update flutter_tizen_engine_unittest (localization) * Rename file : settings_channel_device.cc -> settings_channel_tizen.cc settings_channel_stub.cc -> settings_channel_linux.cc Signed-off-by: MuHong Byun <[email protected]> * Apply review's comment Signed-off-by: MuHong Byun <[email protected]> * Add review's commit Signed-off-by: MuHong Byun <[email protected]>
swift-kim
pushed a commit
that referenced
this pull request
Nov 14, 2021
* Add setting channel unit test Signed-off-by: MuHong Byun <[email protected]> * Add localization_channel unit test Signed-off-by: MuHong Byun <[email protected]> * Revert "Add localization_channel unit test" This reverts commit fd3997d. * Update minor things: * Update flutter_tizen_engine_unittest (localization) * Rename file : settings_channel_device.cc -> settings_channel_tizen.cc settings_channel_stub.cc -> settings_channel_linux.cc Signed-off-by: MuHong Byun <[email protected]> * Apply review's comment Signed-off-by: MuHong Byun <[email protected]> * Add review's commit Signed-off-by: MuHong Byun <[email protected]>
swift-kim
pushed a commit
that referenced
this pull request
Dec 9, 2021
* Add setting channel unit test Signed-off-by: MuHong Byun <[email protected]> * Add localization_channel unit test Signed-off-by: MuHong Byun <[email protected]> * Revert "Add localization_channel unit test" This reverts commit fd3997d. * Update minor things: * Update flutter_tizen_engine_unittest (localization) * Rename file : settings_channel_device.cc -> settings_channel_tizen.cc settings_channel_stub.cc -> settings_channel_linux.cc Signed-off-by: MuHong Byun <[email protected]> * Apply review's comment Signed-off-by: MuHong Byun <[email protected]> * Add review's commit Signed-off-by: MuHong Byun <[email protected]>
swift-kim
pushed a commit
that referenced
this pull request
Dec 17, 2021
* Add setting channel unit test * Update minor things: * Update flutter_tizen_engine_unittest (localization) * Rename file : settings_channel_device.cc -> settings_channel_tizen.cc settings_channel_stub.cc -> settings_channel_linux.cc * Apply review's comment Signed-off-by: MuHong Byun <[email protected]>
swift-kim
pushed a commit
that referenced
this pull request
Feb 7, 2022
* Add setting channel unit test * Update minor things: * Update flutter_tizen_engine_unittest (localization) * Rename file : settings_channel_device.cc -> settings_channel_tizen.cc settings_channel_stub.cc -> settings_channel_linux.cc * Apply review's comment Signed-off-by: MuHong Byun <[email protected]>
swift-kim
pushed a commit
that referenced
this pull request
Feb 11, 2022
* Add setting channel unit test * Update minor things: * Update flutter_tizen_engine_unittest (localization) * Rename file : settings_channel_device.cc -> settings_channel_tizen.cc settings_channel_stub.cc -> settings_channel_linux.cc * Apply review's comment Signed-off-by: MuHong Byun <[email protected]>
swift-kim
pushed a commit
that referenced
this pull request
May 12, 2022
* Add setting channel unit test * Update minor things: * Update flutter_tizen_engine_unittest (localization) * Rename file : settings_channel_device.cc -> settings_channel_tizen.cc settings_channel_stub.cc -> settings_channel_linux.cc * Apply review's comment Signed-off-by: MuHong Byun <[email protected]>
swift-kim
pushed a commit
that referenced
this pull request
Aug 5, 2022
* Add setting channel unit test * Update minor things: * Update flutter_tizen_engine_unittest (localization) * Rename file : settings_channel_device.cc -> settings_channel_tizen.cc settings_channel_stub.cc -> settings_channel_linux.cc Signed-off-by: MuHong Byun <[email protected]>
swift-kim
pushed a commit
that referenced
this pull request
Sep 1, 2022
* Dries up GN rules for Metal and OpenGL ES shader compilation and embedding in a target binary. * Adds support for shader compile time macro definitions. This is so that workarounds for specific shader backends can be implemented. In the case of this patch, there are temporary OpenGLES workaround for users of instancing and SSBOs. These will be removed when I rework glyph rendering to not use these features that are missing in legacy targets. * Since there is no concept of an OpenGLES shader library akin to a `.metallib`, adds a target called `blobcat` that concatenates shader blobs into single blob that can be embedded into a target binary. No parsing or data copying is necessary. * `imgui_raster.vert` has been rewritten to work around the absence of unsigned integer types in legacy backends.
swift-kim
pushed a commit
that referenced
this pull request
Sep 1, 2022
* Add setting channel unit test * Update minor things: * Update flutter_tizen_engine_unittest (localization) * Rename file : settings_channel_device.cc -> settings_channel_tizen.cc settings_channel_stub.cc -> settings_channel_linux.cc Signed-off-by: MuHong Byun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.