Replace LocalizationChannel with system_utils #147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swift-kim
force-pushed
the
remove-localization-channel
branch
2 times, most recently
from
07985a7 to
b338e26
Compare
I totally agree with you! The only reason I'm wary of the _linux suffix is that the linux port is already in use. |
swift-kim
force-pushed
the
remove-localization-channel
branch
2 times, most recently
from
f79e068 to
2359b26
Compare
|
I got following error code at x64 build |
swift-kim
force-pushed
the
remove-localization-channel
branch
from
2359b26 to
3e48787
Compare
|
@bwikbs Uh, my mistake. Something went wrong during the last rebase. The error should have been fixed now. |
swift-kim
added a commit
that referenced
this pull request
Sep 27, 2021
* Remove LocalizationChannel and move the logic to FlutterTizenEngine * Create system_utils and add the desktop implementation * Organize includes
swift-kim
added a commit
that referenced
this pull request
Nov 14, 2021
* Remove LocalizationChannel and move the logic to FlutterTizenEngine * Create system_utils and add the desktop implementation * Organize includes
swift-kim
added a commit
that referenced
this pull request
Dec 9, 2021
* Remove LocalizationChannel and move the logic to FlutterTizenEngine * Create system_utils and add the desktop implementation * Organize includes
swift-kim
added a commit
that referenced
this pull request
Dec 17, 2021
* Remove LocalizationChannel and move the logic to FlutterTizenEngine * Create system_utils and add the desktop implementation * Organize includes
swift-kim
added a commit
that referenced
this pull request
Feb 7, 2022
* Remove LocalizationChannel and move the logic to FlutterTizenEngine * Create system_utils and add the desktop implementation * Organize includes
swift-kim
added a commit
that referenced
this pull request
Feb 11, 2022
* Remove LocalizationChannel and move the logic to FlutterTizenEngine * Create system_utils and add the desktop implementation * Organize includes
swift-kim
added a commit
that referenced
this pull request
May 12, 2022
* Remove LocalizationChannel and move the logic to FlutterTizenEngine * Create system_utils and add the desktop implementation * Organize includes
swift-kim
added a commit
that referenced
this pull request
Aug 5, 2022
* Remove LocalizationChannel and move the logic to FlutterTizenEngine * Create system_utils and add the desktop implementation * Organize includes
swift-kim
pushed a commit
that referenced
this pull request
Sep 1, 2022
swift-kim
added a commit
that referenced
this pull request
Sep 1, 2022
* Remove LocalizationChannel and move the logic to FlutterTizenEngine * Create system_utils and add the desktop implementation * Organize includes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LocalizationChannel, because it doesn't act like a channel or plugin.system_utils.h, similarly to other platform embedders. More functions may be added in this file in the future.system_utils_tizen.ccandsystem_utils_linux.ccfor the Tizen and Linux x64 embedders respectively.Note:
SendPlatformResolvedLocalemethod has been removed because it's not used by anything. The functionality has been moved to the embedder API (FlutterProjectArgs.compute_platform_resolved_locale_callback). I don't think we need to implement it.@bbrto21 and I have agreed to use the
_tizen.ccand_linux.ccfilename suffixes for Tizen and Linux-specific implementations. How do you think? @bwikbs (The use of_stub.ccis to indicate the "unimplemented" state of the code and should be eliminated eventually.)