Skip to content

Replace LocalizationChannel with system_utils #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 19, 2021
Merged

Replace LocalizationChannel with system_utils #147

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c53db8c
Remove LocalizationChannel and move the logic to FlutterTizenEngine
swift-kim Jul 15, 2021
2a72658
Create system_utils and add the desktop implementation
swift-kim Jul 16, 2021
3e48787
Organize includes
swift-kim Jul 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions shell/platform/tizen/BUILD.gn
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,12 +127,12 @@ template("embedder_for_profile") {

sources = _flutter_tizen_source
sources += [
"channels/localization_channel.cc",
"channels/platform_channel.cc",
"channels/settings_channel.cc",
"channels/settings_channel_tizen.cc",
"external_texture_pixel_gl.cc",
"external_texture_surface_gl.cc",
"system_utils_tizen.cc",
"tizen_log.cc",
]

Expand Down Expand Up @@ -244,12 +244,12 @@ template("embedder_executable") {

sources = _flutter_tizen_source
sources += [
"channels/localization_channel_stub.cc",
"channels/platform_channel_stub.cc",
"channels/settings_channel.cc",
"channels/settings_channel_linux.cc",
"external_texture_pixel_gl_stub.cc",
"external_texture_surface_gl_stub.cc",
"system_utils_linux.cc",
"tizen_log_stub.cc",
"tizen_renderer_evas_gl.cc",
]
Expand Down
204 changes: 0 additions & 204 deletions shell/platform/tizen/channels/localization_channel.cc
View file
Open in desktop

This file was deleted.

31 changes: 0 additions & 31 deletions shell/platform/tizen/channels/localization_channel.h
View file
Open in desktop

This file was deleted.

15 changes: 0 additions & 15 deletions shell/platform/tizen/channels/localization_channel_stub.cc
View file
Open in desktop

This file was deleted.

3 changes: 1 addition & 2 deletions shell/platform/tizen/channels/settings_channel_linux.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,7 @@

#include "settings_channel.h"

#include <chrono>
#include <ctime>
#include <locale>

namespace flutter {

Expand Down
3 changes: 2 additions & 1 deletion shell/platform/tizen/channels/settings_channel_tizen.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,10 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

#include <system/system_settings.h>
#include "settings_channel.h"

#include <system/system_settings.h>

namespace flutter {

static void OnSettingsChangedCallback(system_settings_key_e key,
Expand Down
10 changes: 5 additions & 5 deletions shell/platform/tizen/flutter_tizen.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,11 @@ void FlutterDesktopMessengerSetCallback(FlutterDesktopMessengerRef messenger,
}

void FlutterDesktopNotifyLocaleChange(FlutterDesktopEngineRef engine) {
EngineFromHandle(engine)->localization_channel->SendLocales();
EngineFromHandle(engine)->SetupLocales();
}

void FlutterDesktopNotifyLowMemoryWarning(FlutterDesktopEngineRef engine) {
EngineFromHandle(engine)->NotifyLowMemoryWarning();
}

void FlutterDesktopNotifyAppIsInactive(FlutterDesktopEngineRef engine) {
Expand All @@ -136,10 +140,6 @@ void FlutterDesktopNotifyAppIsDetached(FlutterDesktopEngineRef engine) {
EngineFromHandle(engine)->lifecycle_channel->AppIsDetached();
}

void FlutterDesktopNotifyLowMemoryWarning(FlutterDesktopEngineRef engine) {
EngineFromHandle(engine)->NotifyLowMemoryWarning();
}

void FlutterRegisterViewFactory(
FlutterDesktopPluginRegistrarRef registrar,
const char* view_type,
Expand Down
Loading