Skip to content

[webview_flutter] Apply texture api change #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

bwikbs
Copy link
Member

@bwikbs bwikbs commented May 14, 2021

Signed-off-by: MuHong Byun [email protected]

@bwikbs
Copy link
Member Author

bwikbs commented May 14, 2021

It's rough draft base on @xiaowei-guan 's guide.
It doesn't work yet, but it hasn't been analyzed what's the problem.

@bwikbs bwikbs force-pushed the webview_apply_api_change_210514 branch 2 times, most recently from 0a9ca71 to 6fe3f64 Compare May 20, 2021 03:04
@bwikbs bwikbs force-pushed the webview_apply_api_change_210514 branch from 6fe3f64 to e36ea2f Compare May 20, 2021 04:41
@bwikbs bwikbs marked this pull request as ready for review May 25, 2021 03:26
@bwikbs bwikbs requested review from seungsoo47 and bbrto21 May 25, 2021 03:26
@bwikbs bwikbs force-pushed the webview_apply_api_change_210514 branch from f7f878c to 7cf9518 Compare May 25, 2021 23:11
@bwikbs bwikbs force-pushed the webview_apply_api_change_210514 branch from 0928e2d to 31d6176 Compare May 26, 2021 07:58
@swift-kim
Copy link
Member

Not directly related to the texture API change, but we need to organize some unused #include's across this plugin. e.g. Some headers included in webview_flutter_tizen_plugin.cc are redundant.

Copy link
Contributor

@bbrto21 bbrto21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other things LGTM

@bwikbs bwikbs force-pushed the webview_apply_api_change_210514 branch from 2156945 to 4c9cafb Compare May 27, 2021 23:31
@bwikbs
Copy link
Member Author

bwikbs commented May 27, 2021

Not directly related to the texture API change, but we need to organize some unused #include's across this plugin. e.g. Some headers included in webview_flutter_tizen_plugin.cc are redundant.

👌

@bwikbs bwikbs force-pushed the webview_apply_api_change_210514 branch from 4c9cafb to c951d1d Compare May 27, 2021 23:36
@bbrto21 bbrto21 merged commit 8c60c51 into flutter-tizen:master Jun 1, 2021
@swift-kim
Copy link
Member

swift-kim commented Jun 1, 2021

@bbrto21 @bwikbs
You need to update the package version and the CHANGELOG file if you want to publish this change on pub.dev.

A new engine release that contains the change flutter-tizen/engine#86 should be released before that.

@bwikbs
Copy link
Member Author

bwikbs commented Jun 1, 2021

@swift-kim ok. got it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants