Skip to content

[multi-packages] Fix issues from static analysis #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 10, 2021
Merged

[multi-packages] Fix issues from static analysis #264

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/battery/tizen/src/battery_tizen_plugin.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ class BatteryTizenPlugin : public flutter::Plugin {
std::unique_ptr<flutter::EventChannel<flutter::EncodableValue>>
event_channel_;
std::unique_ptr<flutter::EventSink<flutter::EncodableValue>> events_;
bool is_full_;
bool is_full_ = false;
};

void BatteryTizenPluginRegisterWithRegistrar(
Expand Down
2 changes: 1 addition & 1 deletion packages/battery_plus/tizen/src/battery_plus_tizen_plugin.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ class BatteryPlusTizenPlugin : public flutter::Plugin {
std::unique_ptr<flutter::EventChannel<flutter::EncodableValue>>
event_channel_;
std::unique_ptr<flutter::EventSink<flutter::EncodableValue>> events_;
bool is_full_;
bool is_full_ = false;
};

void BatteryPlusTizenPluginRegisterWithRegistrar(
Expand Down
1 change: 1 addition & 0 deletions packages/camera/tizen/src/camera_device.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,7 @@ static RecorderOrientationTag ChooseRecorderOrientationTag(
break;
case OrientationType::kLandscapeRight:
tag = RecorderOrientationTag::kNone;
break;
default:
LOG_ERROR("Unknown RecorderOrientationTag!");
break;
Expand Down
6 changes: 3 additions & 3 deletions packages/image_picker/tizen/src/image_resize.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,9 @@ class ImageResize {
image_util_image_h& dst_image);
bool EncodeImage(image_util_encode_h encode_h, image_util_image_h dst_image,
image_util_type_e encoder_type, const std::string& dst_file);
unsigned int max_width_;
unsigned int max_height_;
int quality_;
unsigned int max_width_ = 0;
unsigned int max_height_ = 0;
int quality_ = 0;
};

#endif
2 changes: 1 addition & 1 deletion packages/webview_flutter/tizen/src/webview.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,7 +323,7 @@ void WebView::ApplySettings(flutter::EncodableMap settings) {
// NOTE: Not supported by LWE on Tizen.
} else if ("gestureNavigationEnabled" == k) {
// NOTE: Not supported by LWE on Tizen.
} else if ("allowsInlineMediaPlayback") {
} else if ("allowsInlineMediaPlayback" == k) {
// no-op inline media playback is always allowed on Tizen.
} else if ("userAgent" == k) {
if (std::holds_alternative<std::string>(val)) {
Expand Down