-
Notifications
You must be signed in to change notification settings - Fork 51
[video_player_avplay]Add setData and getData interface #822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[video_player_avplay]Add setData and getData interface #822
Conversation
cd858a1
to
b705706
Compare
ac7e675
to
94e24e0
Compare
Before I get into review... |
e828d2d
to
e40684a
Compare
.clang-format-ignore for rapidjson.> Before I get into review... rapid json is an external library. If clang-format updated rapidjson should also be updated. How about applying I have tried to use .clang-format-ignore, but it doesn't work. |
|
Oh I'm sorry. I tested it wrong, I was under the mistaken think that it worked. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this API also be called in advance like setStreamingProperty?
packages/video_player_avplay/lib/video_player_platform_interface.dart
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this API only provide DashProperty? Are there any plans to provide other properties?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but it staill has issue with mpeghMetadata, I'm checking with MM team.
Once this is fixed, please verify the behavior and merge.
The MM team member said that mpeghMetadata doesn't open for 3rd-party, I have deleted it form DashPropertyType enum. |
#821
new interface setData and getData for dash player: