Skip to content

[in_app_purchase] Upgrade to latest version and add 'countryCode' API #827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Mar 11, 2025
Merged

[in_app_purchase] Upgrade to latest version and add 'countryCode' API #827

merged 19 commits into from
Mar 11, 2025

Conversation

gin7773
Copy link
Contributor

@gin7773 gin7773 commented Mar 6, 2025

Main changes:

  • Upgrade to 3.2.0 version
  • Add 'countryCode' API

@JSUYA
Copy link
Member

JSUYA commented Mar 6, 2025

Please see this comment. #822 (comment)

seungsoo47
seungsoo47 reviewed Mar 6, 2025
View reviewed changes
Copy link
Contributor

@seungsoo47 seungsoo47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few minor comments.

@JSUYA
Copy link
Member

JSUYA commented Mar 6, 2025

Please see this comment. #822 (comment)

please ignore this comment.

@gin7773 gin7773 requested a review from JSUYA March 7, 2025 06:21
JSUYA
JSUYA reviewed Mar 7, 2025
View reviewed changes
Copy link
Member

@JSUYA JSUYA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update plugin version(0.0.0 to 0.1.1), CHANGELOG.md and README.me?
and
you should update example code. please refer to this.
(You don't need to add other platform's to example.)

JSUYA
JSUYA reviewed Mar 7, 2025
View reviewed changes
Copy link
Member

@JSUYA JSUYA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now, billing_manager_wrapper.dart seems more appropriate as billing_manager.dart(rather than a wrapper). It seems more natural to delete the billing_manager_wrappers directory and move billing_manager.dart to src directory.

@gin7773
Copy link
Contributor Author

gin7773 commented Mar 10, 2025

Could you update plugin version(0.0.0 to 0.1.1), CHANGELOG.md and README.me? and you should update example code. please refer to this. (You don't need to add other platform's to example.)

Done

JSUYA
JSUYA approved these changes Mar 10, 2025
View reviewed changes
Copy link
Member

@JSUYA JSUYA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
waiting for @xiaowei-guan 's confirm

@xiaowei-guan xiaowei-guan merged commit 7ab117b into flutter-tizen:master Mar 11, 2025
6 checks passed
@xiaowei-guan xiaowei-guan mentioned this pull request Mar 11, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JSUYA JSUYA JSUYA approved these changes

@seungsoo47 seungsoo47 seungsoo47 left review comments

@xiaowei-guan xiaowei-guan xiaowei-guan approved these changes

Assignees
No one assigned
Labels
p: in_app_purchase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gin7773 @JSUYA @seungsoo47 @xiaowei-guan