Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Enable lazy-async-stacks by-default in all modes (2) #19270

Merged
merged 1 commit into from Jul 29, 2020
Merged

Enable lazy-async-stacks by-default in all modes (2) #19270

merged 1 commit into from Jul 29, 2020

Conversation

ghost
Copy link

@ghost ghost commented Jun 24, 2020

This is a second attempt at #16556 which was reverted in #16781.

I have manually run the offending test locally and found no issues:

$ cd ~/src/flutter/flutter/ 
$ SHARD=tool_tests SUBSHARD=integration ./bin/cache/dart-sdk/bin/dart ./dev/bots/test.dart --local-engine host_debug

Original CL description:

This was already enabled by-default in AOT mode in [0] - which made the
gen_snapshot invocations use "--lazy-async-stacks --no-causal-async-stacks".

This change does the same with the engine defaults, which makes this be enabled
by-default in JIT mode as well.

See go/dart-10x-faster-async for more information.

[0] flutter/flutter@3478232

@ghost
Copy link
Author

ghost commented Jun 25, 2020

+CC:@mkustermann

@ghost
Copy link
Author

ghost commented Jun 25, 2020

For some reason the build statuses aren't updating, but AFAICT they've all passed.

@ghost ghost marked this pull request as ready for review June 25, 2020 10:40
@fluttergithubbot
Copy link
Contributor

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@auto-assign auto-assign bot requested a review from jason-simmons June 25, 2020 10:40
@ghost
Copy link
Author

ghost commented Jun 26, 2020

I've amended my PR to now include a couple of missing changes from the original CL (Thanks Martin!), which I think got lost because of diffs resulting from the recent terminology clean-up (AllowList, ...).

Also based on feedback I've verified the tests still pass --local-engine-src-path:

~/src/flutter/flutter/> SHARD=tool_tests SUBSHARD=integration ./bin/cache/dart-sdk/bin/dart ./dev/bots/test.dart --local-engi
ne host_debug --local-engine-src-path=~/src/flutter/engine/src

@ghost
Copy link
Author

ghost commented Jun 26, 2020

Another small amend to address the failing test.
Looks like the original CL contained a broken test, which I've now fixed. (Though I'm not a 100% on what the original intent of the test was.)

@nturgut
Copy link
Contributor

nturgut commented Jun 26, 2020

@cskau-g for failing Mac Web Engine test, the PR needs to be rebased to include commit: d758e06

@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no and removed cla: yes labels Jul 7, 2020
@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Jul 7, 2020
@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no and removed cla: yes labels Jul 8, 2020
@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Jul 8, 2020
@ghost
Copy link
Author

ghost commented Jul 21, 2020

Friendly ping for review

@jonahwilliams
Copy link
Member

FYI @zanderso

@ghost ghost deleted the labd branch July 30, 2020 08:49
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 30, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 30, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 30, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 30, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 30, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 30, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 30, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 30, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 30, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 30, 2020
jason-simmons added a commit to jason-simmons/flutter_engine that referenced this pull request Jul 30, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 31, 2020
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 31, 2020
iskakaushik pushed a commit to flutter/flutter that referenced this pull request Jul 31, 2020
* 4521162 Roll Skia from 39d1c1ebb607 to 3a608e5bc9d5 (1 revision) (flutter/engine#20101)

* b265bd2 Roll Skia from 3a608e5bc9d5 to 620bfa3fffba (1 revision) (flutter/engine#20102)

* 36c5f60 Roll Skia from 620bfa3fffba to 4866d0ad5f3c (1 revision) (flutter/engine#20104)

* 06fef5e Enable lazy-async-stacks by-default in all modes (2) (flutter/engine#19270)

* d71b11f Roll Fuchsia Linux SDK from ETPOTPepP... to ROYgzKMaF... (flutter/engine#20105)

* 42e4ebf Roll Skia from 4866d0ad5f3c to c34efe0da102 (1 revision) (flutter/engine#20108)

* 3a65b1a Roll Skia from c34efe0da102 to 8c7ecc1c06f4 (1 revision) (flutter/engine#20109)

* ad99f5e Roll Skia from 8c7ecc1c06f4 to 4f587337c306 (1 revision) (flutter/engine#20110)

* f0cc38f [web] Set correct defaults for text in canvas (flutter/engine#20067)

* 02f9ed9 Roll Fuchsia Mac SDK from 5dM55hp8B... to hzo88TZzN... (flutter/engine#20113)

* 34389f5 Roll Skia from 4f587337c306 to 96d6c6f04dcb (4 revisions) (flutter/engine#20114)

* 49a40fa Enabled linting on engine.cc (flutter/engine#19981)

* b955e15 Manual roll of Dart from 24c7666def...40fd1c456e (flutter/engine#20092)

* 145ef60 Remove confusing logs (flutter/engine#20121)

* 8fc3926 Roll Skia from 96d6c6f04dcb to 57d859edd3c4 (16 revisions) (flutter/engine#20126)

* ec9e17c Roll zlib (flutter/engine#20119)

* f288fe5 [web] Enable canvas measurement by default (flutter/engine#19924)

* 8464208 Add missing MouseCursorPlugin destroy call (flutter/engine#19968)

* 5498add Roll Skia from 57d859edd3c4 to 994ce8cf2300 (1 revision) (flutter/engine#20129)

* 9398bc4 Roll Skia from 994ce8cf2300 to 398c654ce7be (2 revisions) (flutter/engine#20133)

* d3bc43e Roll Fuchsia Linux SDK from ROYgzKMaF... to d4pESQYnB... (flutter/engine#20132)

* 4068918 Manual roll of Dart 40fd1c456e...7e8348f4ce (flutter/engine#20125)

* 4c49e0b Manual roll of Dart cb6ed67a73...7e8348f4ce (flutter/engine#20135)

* 4a3688e Roll Skia from 398c654ce7be to a4bbc9d8ec4f (1 revision) (flutter/engine#20136)

* b3c6fd3 Roll Fuchsia Mac SDK from hzo88TZzN... to 3XwiR_wVO... (flutter/engine#20137)

* adb5986 Manual roll of Dart 03e4737f31...cb6ed67a73 (flutter/engine#20138)

* 941c442 Add ALERT SoundType enum value (flutter/engine#20139)

* 19368ef Fix dartdocs of dart:ui (flutter/engine#20140)

* 9dd3d2e Roll Skia from a4bbc9d8ec4f to 94cefeff50d2 (1 revision) (flutter/engine#20141)

* 0fdb141 Roll Dart SDK from 03e4737f3115 to 59600f2b46ef (54 revisions) (flutter/engine#20143)

* 97d6ee2 Roll Skia from 94cefeff50d2 to 5ba6534884d9 (2 revisions) (flutter/engine#20146)

* da3d495 Roll Dart SDK from 59600f2b46ef to 04f4272546af (5 revisions) (flutter/engine#20147)

* 8229df8 Roll Skia from 5ba6534884d9 to e393c61a1563 (1 revision) (flutter/engine#20148)

* 8e1d48e Migrate some Dart_WeakPersistentHandle uses to Dart_FinalizableHandle (flutter/engine#20107)

* 27b61e7 Roll ANGLE to pick up warning fixes (flutter/engine#19105)

* 146d504 Roll Skia from e393c61a1563 to 3136789972ea (5 revisions) (flutter/engine#20150)

* 841b391 Roll Dart SDK from 04f4272546af to e87cb96bb89c (7 revisions) (flutter/engine#20152)

* e9334c9 Roll Skia from 3136789972ea to 5f2b2d6dc691 (5 revisions) (flutter/engine#20153)

* f2b02d8 [iOS] Fixes text input plugin crash (flutter/engine#20127)

* 3ed5893 Roll Skia from 5f2b2d6dc691 to 8cc118dce813 (2 revisions) (flutter/engine#20154)

* 7c5162e Roll Fuchsia Mac SDK from 3XwiR_wVO... to T2xc0OuiK... (flutter/engine#20155)

* e23e477 Lint fixes for fml, tools subdirs (flutter/engine#19990)

* f620eac Roll Dart SDK from e87cb96bb89c to bd528bfbd69d (8 revisions) (flutter/engine#20158)

* e1c9673 Fix targets in build_fuchsia_artifacts (flutter/engine#19794)

* c134e16 add information collection for safari bots (flutter/engine#20123)

* ee4d50c Revert "Enable lazy-async-stacks by-default in all modes (2) (#19270)" (flutter/engine#20165)

* 357b155 Roll Fuchsia Linux SDK from d4pESQYnB... to d_5wDVmBd... (flutter/engine#20161)

* a6cd3eb Fix lint errors in lib/ui (flutter/engine#19988)

* 280bbfc This makes the lint script use multiprocessing to speed it up. (flutter/engine#19987)
Pragya007 pushed a commit to Pragya007/flutter that referenced this pull request Aug 11, 2020
* 4521162 Roll Skia from 39d1c1ebb607 to 3a608e5bc9d5 (1 revision) (flutter/engine#20101)

* b265bd2 Roll Skia from 3a608e5bc9d5 to 620bfa3fffba (1 revision) (flutter/engine#20102)

* 36c5f60 Roll Skia from 620bfa3fffba to 4866d0ad5f3c (1 revision) (flutter/engine#20104)

* 06fef5e Enable lazy-async-stacks by-default in all modes (2) (flutter/engine#19270)

* d71b11f Roll Fuchsia Linux SDK from ETPOTPepP... to ROYgzKMaF... (flutter/engine#20105)

* 42e4ebf Roll Skia from 4866d0ad5f3c to c34efe0da102 (1 revision) (flutter/engine#20108)

* 3a65b1a Roll Skia from c34efe0da102 to 8c7ecc1c06f4 (1 revision) (flutter/engine#20109)

* ad99f5e Roll Skia from 8c7ecc1c06f4 to 4f587337c306 (1 revision) (flutter/engine#20110)

* f0cc38f [web] Set correct defaults for text in canvas (flutter/engine#20067)

* 02f9ed9 Roll Fuchsia Mac SDK from 5dM55hp8B... to hzo88TZzN... (flutter/engine#20113)

* 34389f5 Roll Skia from 4f587337c306 to 96d6c6f04dcb (4 revisions) (flutter/engine#20114)

* 49a40fa Enabled linting on engine.cc (flutter/engine#19981)

* b955e15 Manual roll of Dart from 24c7666def...40fd1c456e (flutter/engine#20092)

* 145ef60 Remove confusing logs (flutter/engine#20121)

* 8fc3926 Roll Skia from 96d6c6f04dcb to 57d859edd3c4 (16 revisions) (flutter/engine#20126)

* ec9e17c Roll zlib (flutter/engine#20119)

* f288fe5 [web] Enable canvas measurement by default (flutter/engine#19924)

* 8464208 Add missing MouseCursorPlugin destroy call (flutter/engine#19968)

* 5498add Roll Skia from 57d859edd3c4 to 994ce8cf2300 (1 revision) (flutter/engine#20129)

* 9398bc4 Roll Skia from 994ce8cf2300 to 398c654ce7be (2 revisions) (flutter/engine#20133)

* d3bc43e Roll Fuchsia Linux SDK from ROYgzKMaF... to d4pESQYnB... (flutter/engine#20132)

* 4068918 Manual roll of Dart 40fd1c456e...7e8348f4ce (flutter/engine#20125)

* 4c49e0b Manual roll of Dart cb6ed67a73...7e8348f4ce (flutter/engine#20135)

* 4a3688e Roll Skia from 398c654ce7be to a4bbc9d8ec4f (1 revision) (flutter/engine#20136)

* b3c6fd3 Roll Fuchsia Mac SDK from hzo88TZzN... to 3XwiR_wVO... (flutter/engine#20137)

* adb5986 Manual roll of Dart 03e4737f31...cb6ed67a73 (flutter/engine#20138)

* 941c442 Add ALERT SoundType enum value (flutter/engine#20139)

* 19368ef Fix dartdocs of dart:ui (flutter/engine#20140)

* 9dd3d2e Roll Skia from a4bbc9d8ec4f to 94cefeff50d2 (1 revision) (flutter/engine#20141)

* 0fdb141 Roll Dart SDK from 03e4737f3115 to 59600f2b46ef (54 revisions) (flutter/engine#20143)

* 97d6ee2 Roll Skia from 94cefeff50d2 to 5ba6534884d9 (2 revisions) (flutter/engine#20146)

* da3d495 Roll Dart SDK from 59600f2b46ef to 04f4272546af (5 revisions) (flutter/engine#20147)

* 8229df8 Roll Skia from 5ba6534884d9 to e393c61a1563 (1 revision) (flutter/engine#20148)

* 8e1d48e Migrate some Dart_WeakPersistentHandle uses to Dart_FinalizableHandle (flutter/engine#20107)

* 27b61e7 Roll ANGLE to pick up warning fixes (flutter/engine#19105)

* 146d504 Roll Skia from e393c61a1563 to 3136789972ea (5 revisions) (flutter/engine#20150)

* 841b391 Roll Dart SDK from 04f4272546af to e87cb96bb89c (7 revisions) (flutter/engine#20152)

* e9334c9 Roll Skia from 3136789972ea to 5f2b2d6dc691 (5 revisions) (flutter/engine#20153)

* f2b02d8 [iOS] Fixes text input plugin crash (flutter/engine#20127)

* 3ed5893 Roll Skia from 5f2b2d6dc691 to 8cc118dce813 (2 revisions) (flutter/engine#20154)

* 7c5162e Roll Fuchsia Mac SDK from 3XwiR_wVO... to T2xc0OuiK... (flutter/engine#20155)

* e23e477 Lint fixes for fml, tools subdirs (flutter/engine#19990)

* f620eac Roll Dart SDK from e87cb96bb89c to bd528bfbd69d (8 revisions) (flutter/engine#20158)

* e1c9673 Fix targets in build_fuchsia_artifacts (flutter/engine#19794)

* c134e16 add information collection for safari bots (flutter/engine#20123)

* ee4d50c Revert "Enable lazy-async-stacks by-default in all modes (2) (flutter#19270)" (flutter/engine#20165)

* 357b155 Roll Fuchsia Linux SDK from d4pESQYnB... to d_5wDVmBd... (flutter/engine#20161)

* a6cd3eb Fix lint errors in lib/ui (flutter/engine#19988)

* 280bbfc This makes the lint script use multiprocessing to speed it up. (flutter/engine#19987)
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
* 4521162 Roll Skia from 39d1c1ebb607 to 3a608e5bc9d5 (1 revision) (flutter/engine#20101)

* b265bd2 Roll Skia from 3a608e5bc9d5 to 620bfa3fffba (1 revision) (flutter/engine#20102)

* 36c5f60 Roll Skia from 620bfa3fffba to 4866d0ad5f3c (1 revision) (flutter/engine#20104)

* 06fef5e Enable lazy-async-stacks by-default in all modes (2) (flutter/engine#19270)

* d71b11f Roll Fuchsia Linux SDK from ETPOTPepP... to ROYgzKMaF... (flutter/engine#20105)

* 42e4ebf Roll Skia from 4866d0ad5f3c to c34efe0da102 (1 revision) (flutter/engine#20108)

* 3a65b1a Roll Skia from c34efe0da102 to 8c7ecc1c06f4 (1 revision) (flutter/engine#20109)

* ad99f5e Roll Skia from 8c7ecc1c06f4 to 4f587337c306 (1 revision) (flutter/engine#20110)

* f0cc38f [web] Set correct defaults for text in canvas (flutter/engine#20067)

* 02f9ed9 Roll Fuchsia Mac SDK from 5dM55hp8B... to hzo88TZzN... (flutter/engine#20113)

* 34389f5 Roll Skia from 4f587337c306 to 96d6c6f04dcb (4 revisions) (flutter/engine#20114)

* 49a40fa Enabled linting on engine.cc (flutter/engine#19981)

* b955e15 Manual roll of Dart from 24c7666def...40fd1c456e (flutter/engine#20092)

* 145ef60 Remove confusing logs (flutter/engine#20121)

* 8fc3926 Roll Skia from 96d6c6f04dcb to 57d859edd3c4 (16 revisions) (flutter/engine#20126)

* ec9e17c Roll zlib (flutter/engine#20119)

* f288fe5 [web] Enable canvas measurement by default (flutter/engine#19924)

* 8464208 Add missing MouseCursorPlugin destroy call (flutter/engine#19968)

* 5498add Roll Skia from 57d859edd3c4 to 994ce8cf2300 (1 revision) (flutter/engine#20129)

* 9398bc4 Roll Skia from 994ce8cf2300 to 398c654ce7be (2 revisions) (flutter/engine#20133)

* d3bc43e Roll Fuchsia Linux SDK from ROYgzKMaF... to d4pESQYnB... (flutter/engine#20132)

* 4068918 Manual roll of Dart 40fd1c456e...7e8348f4ce (flutter/engine#20125)

* 4c49e0b Manual roll of Dart cb6ed67a73...7e8348f4ce (flutter/engine#20135)

* 4a3688e Roll Skia from 398c654ce7be to a4bbc9d8ec4f (1 revision) (flutter/engine#20136)

* b3c6fd3 Roll Fuchsia Mac SDK from hzo88TZzN... to 3XwiR_wVO... (flutter/engine#20137)

* adb5986 Manual roll of Dart 03e4737f31...cb6ed67a73 (flutter/engine#20138)

* 941c442 Add ALERT SoundType enum value (flutter/engine#20139)

* 19368ef Fix dartdocs of dart:ui (flutter/engine#20140)

* 9dd3d2e Roll Skia from a4bbc9d8ec4f to 94cefeff50d2 (1 revision) (flutter/engine#20141)

* 0fdb141 Roll Dart SDK from 03e4737f3115 to 59600f2b46ef (54 revisions) (flutter/engine#20143)

* 97d6ee2 Roll Skia from 94cefeff50d2 to 5ba6534884d9 (2 revisions) (flutter/engine#20146)

* da3d495 Roll Dart SDK from 59600f2b46ef to 04f4272546af (5 revisions) (flutter/engine#20147)

* 8229df8 Roll Skia from 5ba6534884d9 to e393c61a1563 (1 revision) (flutter/engine#20148)

* 8e1d48e Migrate some Dart_WeakPersistentHandle uses to Dart_FinalizableHandle (flutter/engine#20107)

* 27b61e7 Roll ANGLE to pick up warning fixes (flutter/engine#19105)

* 146d504 Roll Skia from e393c61a1563 to 3136789972ea (5 revisions) (flutter/engine#20150)

* 841b391 Roll Dart SDK from 04f4272546af to e87cb96bb89c (7 revisions) (flutter/engine#20152)

* e9334c9 Roll Skia from 3136789972ea to 5f2b2d6dc691 (5 revisions) (flutter/engine#20153)

* f2b02d8 [iOS] Fixes text input plugin crash (flutter/engine#20127)

* 3ed5893 Roll Skia from 5f2b2d6dc691 to 8cc118dce813 (2 revisions) (flutter/engine#20154)

* 7c5162e Roll Fuchsia Mac SDK from 3XwiR_wVO... to T2xc0OuiK... (flutter/engine#20155)

* e23e477 Lint fixes for fml, tools subdirs (flutter/engine#19990)

* f620eac Roll Dart SDK from e87cb96bb89c to bd528bfbd69d (8 revisions) (flutter/engine#20158)

* e1c9673 Fix targets in build_fuchsia_artifacts (flutter/engine#19794)

* c134e16 add information collection for safari bots (flutter/engine#20123)

* ee4d50c Revert "Enable lazy-async-stacks by-default in all modes (2) (flutter#19270)" (flutter/engine#20165)

* 357b155 Roll Fuchsia Linux SDK from d4pESQYnB... to d_5wDVmBd... (flutter/engine#20161)

* a6cd3eb Fix lint errors in lib/ui (flutter/engine#19988)

* 280bbfc This makes the lint script use multiprocessing to speed it up. (flutter/engine#19987)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants