Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Migrate some Dart_WeakPersistentHandle uses to Dart_FinalizableHandle #20107

Merged
merged 1 commit into from
Jul 30, 2020
Merged

Migrate some Dart_WeakPersistentHandle uses to Dart_FinalizableHandle #20107

merged 1 commit into from
Jul 30, 2020

Conversation

dcharkes
Copy link
Contributor

Description

The PR is migrating some users of Dart_WeakPersistentHandle because the semantics of that is changing to be non-auto-deleting. See https://dart-review.googlesource.com/c/sdk/+/151525. This is the non-breaking change part of #19843.

Related Issues

dart-lang/sdk#42312

Tests

I did not write new tests but ran the existing tests on HHH infrastructure.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the contributor guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the C++, Objective-C, Java style guides for the engine.
  • I read the tree hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation.
  • All existing and new tests are passing.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

This is the non-breaking change part of #19843.

Did any tests fail when you ran them? Please read handling breaking changes.

  • No, no existing tests failed, so this is not a breaking change.

@dcharkes dcharkes requested a review from mkustermann July 29, 2020 10:19
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@dcharkes dcharkes mentioned this pull request Jul 29, 2020
Merged
12 tasks
@auto-assign auto-assign bot requested a review from iskakaushik July 29, 2020 10:20
@dcharkes
Copy link
Contributor Author

dcharkes commented Jul 29, 2020 •
edited
Loading

So, Dart has rolled to 2.10 (commit of 7 days ago), but not yet to the commit where we added Dart_NewFinalizableHandle. I'll poke this PR again when Dart has rolled again.

@dcharkes dcharkes force-pushed the migrate-to-finalizable-handles branch from 7105d51 to 27c156c Compare July 30, 2020 12:38
@dcharkes dcharkes merged commit 8e1d48e into flutter:master Jul 30, 2020
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 30, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 30, 2020
@engine-flutter-autoroll
8e1d48e Migrate some Dart_WeakPersistentHandle uses to Dart_Finalizab…
a31f286 
…leHandle (flutter/engine#20107)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 30, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 30, 2020
@engine-flutter-autoroll
8e1d48e Migrate some Dart_WeakPersistentHandle uses to Dart_Finalizab…
d1807e0 
…leHandle (flutter/engine#20107)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 30, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 30, 2020
@engine-flutter-autoroll
8e1d48e Migrate some Dart_WeakPersistentHandle uses to Dart_Finalizab…
3790721 
…leHandle (flutter/engine#20107)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 30, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 30, 2020
@engine-flutter-autoroll
8e1d48e Migrate some Dart_WeakPersistentHandle uses to Dart_Finalizab…
c81c18d 
…leHandle (flutter/engine#20107)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 30, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 30, 2020
@engine-flutter-autoroll
8e1d48e Migrate some Dart_WeakPersistentHandle uses to Dart_Finalizab…
49ece16 
…leHandle (flutter/engine#20107)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 30, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 30, 2020
@engine-flutter-autoroll
8e1d48e Migrate some Dart_WeakPersistentHandle uses to Dart_Finalizab…
f0e3679 
…leHandle (flutter/engine#20107)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 31, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 31, 2020
@engine-flutter-autoroll
8e1d48e Migrate some Dart_WeakPersistentHandle uses to Dart_Finalizab…
f8a5cb6 
…leHandle (flutter/engine#20107)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 31, 2020
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 31, 2020
@engine-flutter-autoroll
8e1d48e Migrate some Dart_WeakPersistentHandle uses to Dart_Finalizab…
085d426 
…leHandle (flutter/engine#20107)
iskakaushik pushed a commit to flutter/flutter that referenced this pull request Jul 31, 2020
@engine-flutter-autoroll
Roll Engine from a9910e4 to 280bbfc (49 revisions) (#62647)
f06ee8d 
* 4521162 Roll Skia from 39d1c1ebb607 to 3a608e5bc9d5 (1 revision) (flutter/engine#20101)

* b265bd2 Roll Skia from 3a608e5bc9d5 to 620bfa3fffba (1 revision) (flutter/engine#20102)

* 36c5f60 Roll Skia from 620bfa3fffba to 4866d0ad5f3c (1 revision) (flutter/engine#20104)

* 06fef5e Enable lazy-async-stacks by-default in all modes (2) (flutter/engine#19270)

* d71b11f Roll Fuchsia Linux SDK from ETPOTPepP... to ROYgzKMaF... (flutter/engine#20105)

* 42e4ebf Roll Skia from 4866d0ad5f3c to c34efe0da102 (1 revision) (flutter/engine#20108)

* 3a65b1a Roll Skia from c34efe0da102 to 8c7ecc1c06f4 (1 revision) (flutter/engine#20109)

* ad99f5e Roll Skia from 8c7ecc1c06f4 to 4f587337c306 (1 revision) (flutter/engine#20110)

* f0cc38f [web] Set correct defaults for text in canvas (flutter/engine#20067)

* 02f9ed9 Roll Fuchsia Mac SDK from 5dM55hp8B... to hzo88TZzN... (flutter/engine#20113)

* 34389f5 Roll Skia from 4f587337c306 to 96d6c6f04dcb (4 revisions) (flutter/engine#20114)

* 49a40fa Enabled linting on engine.cc (flutter/engine#19981)

* b955e15 Manual roll of Dart from 24c7666def...40fd1c456e (flutter/engine#20092)

* 145ef60 Remove confusing logs (flutter/engine#20121)

* 8fc3926 Roll Skia from 96d6c6f04dcb to 57d859edd3c4 (16 revisions) (flutter/engine#20126)

* ec9e17c Roll zlib (flutter/engine#20119)

* f288fe5 [web] Enable canvas measurement by default (flutter/engine#19924)

* 8464208 Add missing MouseCursorPlugin destroy call (flutter/engine#19968)

* 5498add Roll Skia from 57d859edd3c4 to 994ce8cf2300 (1 revision) (flutter/engine#20129)

* 9398bc4 Roll Skia from 994ce8cf2300 to 398c654ce7be (2 revisions) (flutter/engine#20133)

* d3bc43e Roll Fuchsia Linux SDK from ROYgzKMaF... to d4pESQYnB... (flutter/engine#20132)

* 4068918 Manual roll of Dart 40fd1c456e...7e8348f4ce (flutter/engine#20125)

* 4c49e0b Manual roll of Dart cb6ed67a73...7e8348f4ce (flutter/engine#20135)

* 4a3688e Roll Skia from 398c654ce7be to a4bbc9d8ec4f (1 revision) (flutter/engine#20136)

* b3c6fd3 Roll Fuchsia Mac SDK from hzo88TZzN... to 3XwiR_wVO... (flutter/engine#20137)

* adb5986 Manual roll of Dart 03e4737f31...cb6ed67a73 (flutter/engine#20138)

* 941c442 Add ALERT SoundType enum value (flutter/engine#20139)

* 19368ef Fix dartdocs of dart:ui (flutter/engine#20140)

* 9dd3d2e Roll Skia from a4bbc9d8ec4f to 94cefeff50d2 (1 revision) (flutter/engine#20141)

* 0fdb141 Roll Dart SDK from 03e4737f3115 to 59600f2b46ef (54 revisions) (flutter/engine#20143)

* 97d6ee2 Roll Skia from 94cefeff50d2 to 5ba6534884d9 (2 revisions) (flutter/engine#20146)

* da3d495 Roll Dart SDK from 59600f2b46ef to 04f4272546af (5 revisions) (flutter/engine#20147)

* 8229df8 Roll Skia from 5ba6534884d9 to e393c61a1563 (1 revision) (flutter/engine#20148)

* 8e1d48e Migrate some Dart_WeakPersistentHandle uses to Dart_FinalizableHandle (flutter/engine#20107)

* 27b61e7 Roll ANGLE to pick up warning fixes (flutter/engine#19105)

* 146d504 Roll Skia from e393c61a1563 to 3136789972ea (5 revisions) (flutter/engine#20150)

* 841b391 Roll Dart SDK from 04f4272546af to e87cb96bb89c (7 revisions) (flutter/engine#20152)

* e9334c9 Roll Skia from 3136789972ea to 5f2b2d6dc691 (5 revisions) (flutter/engine#20153)

* f2b02d8 [iOS] Fixes text input plugin crash (flutter/engine#20127)

* 3ed5893 Roll Skia from 5f2b2d6dc691 to 8cc118dce813 (2 revisions) (flutter/engine#20154)

* 7c5162e Roll Fuchsia Mac SDK from 3XwiR_wVO... to T2xc0OuiK... (flutter/engine#20155)

* e23e477 Lint fixes for fml, tools subdirs (flutter/engine#19990)

* f620eac Roll Dart SDK from e87cb96bb89c to bd528bfbd69d (8 revisions) (flutter/engine#20158)

* e1c9673 Fix targets in build_fuchsia_artifacts (flutter/engine#19794)

* c134e16 add information collection for safari bots (flutter/engine#20123)

* ee4d50c Revert "Enable lazy-async-stacks by-default in all modes (2) (#19270)" (flutter/engine#20165)

* 357b155 Roll Fuchsia Linux SDK from d4pESQYnB... to d_5wDVmBd... (flutter/engine#20161)

* a6cd3eb Fix lint errors in lib/ui (flutter/engine#19988)

* 280bbfc This makes the lint script use multiprocessing to speed it up. (flutter/engine#19987)
Pragya007 pushed a commit to Pragya007/flutter that referenced this pull request Aug 11, 2020
@engine-flutter-autoroll @Pragya007
Roll Engine from a9910e4 to 280bbfc (49 revisions) (flutter#62647)
4431eb4 
* 4521162 Roll Skia from 39d1c1ebb607 to 3a608e5bc9d5 (1 revision) (flutter/engine#20101)

* b265bd2 Roll Skia from 3a608e5bc9d5 to 620bfa3fffba (1 revision) (flutter/engine#20102)

* 36c5f60 Roll Skia from 620bfa3fffba to 4866d0ad5f3c (1 revision) (flutter/engine#20104)

* 06fef5e Enable lazy-async-stacks by-default in all modes (2) (flutter/engine#19270)

* d71b11f Roll Fuchsia Linux SDK from ETPOTPepP... to ROYgzKMaF... (flutter/engine#20105)

* 42e4ebf Roll Skia from 4866d0ad5f3c to c34efe0da102 (1 revision) (flutter/engine#20108)

* 3a65b1a Roll Skia from c34efe0da102 to 8c7ecc1c06f4 (1 revision) (flutter/engine#20109)

* ad99f5e Roll Skia from 8c7ecc1c06f4 to 4f587337c306 (1 revision) (flutter/engine#20110)

* f0cc38f [web] Set correct defaults for text in canvas (flutter/engine#20067)

* 02f9ed9 Roll Fuchsia Mac SDK from 5dM55hp8B... to hzo88TZzN... (flutter/engine#20113)

* 34389f5 Roll Skia from 4f587337c306 to 96d6c6f04dcb (4 revisions) (flutter/engine#20114)

* 49a40fa Enabled linting on engine.cc (flutter/engine#19981)

* b955e15 Manual roll of Dart from 24c7666def...40fd1c456e (flutter/engine#20092)

* 145ef60 Remove confusing logs (flutter/engine#20121)

* 8fc3926 Roll Skia from 96d6c6f04dcb to 57d859edd3c4 (16 revisions) (flutter/engine#20126)

* ec9e17c Roll zlib (flutter/engine#20119)

* f288fe5 [web] Enable canvas measurement by default (flutter/engine#19924)

* 8464208 Add missing MouseCursorPlugin destroy call (flutter/engine#19968)

* 5498add Roll Skia from 57d859edd3c4 to 994ce8cf2300 (1 revision) (flutter/engine#20129)

* 9398bc4 Roll Skia from 994ce8cf2300 to 398c654ce7be (2 revisions) (flutter/engine#20133)

* d3bc43e Roll Fuchsia Linux SDK from ROYgzKMaF... to d4pESQYnB... (flutter/engine#20132)

* 4068918 Manual roll of Dart 40fd1c456e...7e8348f4ce (flutter/engine#20125)

* 4c49e0b Manual roll of Dart cb6ed67a73...7e8348f4ce (flutter/engine#20135)

* 4a3688e Roll Skia from 398c654ce7be to a4bbc9d8ec4f (1 revision) (flutter/engine#20136)

* b3c6fd3 Roll Fuchsia Mac SDK from hzo88TZzN... to 3XwiR_wVO... (flutter/engine#20137)

* adb5986 Manual roll of Dart 03e4737f31...cb6ed67a73 (flutter/engine#20138)

* 941c442 Add ALERT SoundType enum value (flutter/engine#20139)

* 19368ef Fix dartdocs of dart:ui (flutter/engine#20140)

* 9dd3d2e Roll Skia from a4bbc9d8ec4f to 94cefeff50d2 (1 revision) (flutter/engine#20141)

* 0fdb141 Roll Dart SDK from 03e4737f3115 to 59600f2b46ef (54 revisions) (flutter/engine#20143)

* 97d6ee2 Roll Skia from 94cefeff50d2 to 5ba6534884d9 (2 revisions) (flutter/engine#20146)

* da3d495 Roll Dart SDK from 59600f2b46ef to 04f4272546af (5 revisions) (flutter/engine#20147)

* 8229df8 Roll Skia from 5ba6534884d9 to e393c61a1563 (1 revision) (flutter/engine#20148)

* 8e1d48e Migrate some Dart_WeakPersistentHandle uses to Dart_FinalizableHandle (flutter/engine#20107)

* 27b61e7 Roll ANGLE to pick up warning fixes (flutter/engine#19105)

* 146d504 Roll Skia from e393c61a1563 to 3136789972ea (5 revisions) (flutter/engine#20150)

* 841b391 Roll Dart SDK from 04f4272546af to e87cb96bb89c (7 revisions) (flutter/engine#20152)

* e9334c9 Roll Skia from 3136789972ea to 5f2b2d6dc691 (5 revisions) (flutter/engine#20153)

* f2b02d8 [iOS] Fixes text input plugin crash (flutter/engine#20127)

* 3ed5893 Roll Skia from 5f2b2d6dc691 to 8cc118dce813 (2 revisions) (flutter/engine#20154)

* 7c5162e Roll Fuchsia Mac SDK from 3XwiR_wVO... to T2xc0OuiK... (flutter/engine#20155)

* e23e477 Lint fixes for fml, tools subdirs (flutter/engine#19990)

* f620eac Roll Dart SDK from e87cb96bb89c to bd528bfbd69d (8 revisions) (flutter/engine#20158)

* e1c9673 Fix targets in build_fuchsia_artifacts (flutter/engine#19794)

* c134e16 add information collection for safari bots (flutter/engine#20123)

* ee4d50c Revert "Enable lazy-async-stacks by-default in all modes (2) (flutter#19270)" (flutter/engine#20165)

* 357b155 Roll Fuchsia Linux SDK from d4pESQYnB... to d_5wDVmBd... (flutter/engine#20161)

* a6cd3eb Fix lint errors in lib/ui (flutter/engine#19988)

* 280bbfc This makes the lint script use multiprocessing to speed it up. (flutter/engine#19987)
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
@engine-flutter-autoroll @mingwandroid
Roll Engine from a9910e4 to 280bbfc (49 revisions) (flutter#62647)
2e9a642 
* 4521162 Roll Skia from 39d1c1ebb607 to 3a608e5bc9d5 (1 revision) (flutter/engine#20101)

* b265bd2 Roll Skia from 3a608e5bc9d5 to 620bfa3fffba (1 revision) (flutter/engine#20102)

* 36c5f60 Roll Skia from 620bfa3fffba to 4866d0ad5f3c (1 revision) (flutter/engine#20104)

* 06fef5e Enable lazy-async-stacks by-default in all modes (2) (flutter/engine#19270)

* d71b11f Roll Fuchsia Linux SDK from ETPOTPepP... to ROYgzKMaF... (flutter/engine#20105)

* 42e4ebf Roll Skia from 4866d0ad5f3c to c34efe0da102 (1 revision) (flutter/engine#20108)

* 3a65b1a Roll Skia from c34efe0da102 to 8c7ecc1c06f4 (1 revision) (flutter/engine#20109)

* ad99f5e Roll Skia from 8c7ecc1c06f4 to 4f587337c306 (1 revision) (flutter/engine#20110)

* f0cc38f [web] Set correct defaults for text in canvas (flutter/engine#20067)

* 02f9ed9 Roll Fuchsia Mac SDK from 5dM55hp8B... to hzo88TZzN... (flutter/engine#20113)

* 34389f5 Roll Skia from 4f587337c306 to 96d6c6f04dcb (4 revisions) (flutter/engine#20114)

* 49a40fa Enabled linting on engine.cc (flutter/engine#19981)

* b955e15 Manual roll of Dart from 24c7666def...40fd1c456e (flutter/engine#20092)

* 145ef60 Remove confusing logs (flutter/engine#20121)

* 8fc3926 Roll Skia from 96d6c6f04dcb to 57d859edd3c4 (16 revisions) (flutter/engine#20126)

* ec9e17c Roll zlib (flutter/engine#20119)

* f288fe5 [web] Enable canvas measurement by default (flutter/engine#19924)

* 8464208 Add missing MouseCursorPlugin destroy call (flutter/engine#19968)

* 5498add Roll Skia from 57d859edd3c4 to 994ce8cf2300 (1 revision) (flutter/engine#20129)

* 9398bc4 Roll Skia from 994ce8cf2300 to 398c654ce7be (2 revisions) (flutter/engine#20133)

* d3bc43e Roll Fuchsia Linux SDK from ROYgzKMaF... to d4pESQYnB... (flutter/engine#20132)

* 4068918 Manual roll of Dart 40fd1c456e...7e8348f4ce (flutter/engine#20125)

* 4c49e0b Manual roll of Dart cb6ed67a73...7e8348f4ce (flutter/engine#20135)

* 4a3688e Roll Skia from 398c654ce7be to a4bbc9d8ec4f (1 revision) (flutter/engine#20136)

* b3c6fd3 Roll Fuchsia Mac SDK from hzo88TZzN... to 3XwiR_wVO... (flutter/engine#20137)

* adb5986 Manual roll of Dart 03e4737f31...cb6ed67a73 (flutter/engine#20138)

* 941c442 Add ALERT SoundType enum value (flutter/engine#20139)

* 19368ef Fix dartdocs of dart:ui (flutter/engine#20140)

* 9dd3d2e Roll Skia from a4bbc9d8ec4f to 94cefeff50d2 (1 revision) (flutter/engine#20141)

* 0fdb141 Roll Dart SDK from 03e4737f3115 to 59600f2b46ef (54 revisions) (flutter/engine#20143)

* 97d6ee2 Roll Skia from 94cefeff50d2 to 5ba6534884d9 (2 revisions) (flutter/engine#20146)

* da3d495 Roll Dart SDK from 59600f2b46ef to 04f4272546af (5 revisions) (flutter/engine#20147)

* 8229df8 Roll Skia from 5ba6534884d9 to e393c61a1563 (1 revision) (flutter/engine#20148)

* 8e1d48e Migrate some Dart_WeakPersistentHandle uses to Dart_FinalizableHandle (flutter/engine#20107)

* 27b61e7 Roll ANGLE to pick up warning fixes (flutter/engine#19105)

* 146d504 Roll Skia from e393c61a1563 to 3136789972ea (5 revisions) (flutter/engine#20150)

* 841b391 Roll Dart SDK from 04f4272546af to e87cb96bb89c (7 revisions) (flutter/engine#20152)

* e9334c9 Roll Skia from 3136789972ea to 5f2b2d6dc691 (5 revisions) (flutter/engine#20153)

* f2b02d8 [iOS] Fixes text input plugin crash (flutter/engine#20127)

* 3ed5893 Roll Skia from 5f2b2d6dc691 to 8cc118dce813 (2 revisions) (flutter/engine#20154)

* 7c5162e Roll Fuchsia Mac SDK from 3XwiR_wVO... to T2xc0OuiK... (flutter/engine#20155)

* e23e477 Lint fixes for fml, tools subdirs (flutter/engine#19990)

* f620eac Roll Dart SDK from e87cb96bb89c to bd528bfbd69d (8 revisions) (flutter/engine#20158)

* e1c9673 Fix targets in build_fuchsia_artifacts (flutter/engine#19794)

* c134e16 add information collection for safari bots (flutter/engine#20123)

* ee4d50c Revert "Enable lazy-async-stacks by-default in all modes (2) (flutter#19270)" (flutter/engine#20165)

* 357b155 Roll Fuchsia Linux SDK from d4pESQYnB... to d_5wDVmBd... (flutter/engine#20161)

* a6cd3eb Fix lint errors in lib/ui (flutter/engine#19988)

* 280bbfc This makes the lint script use multiprocessing to speed it up. (flutter/engine#19987)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mkustermann mkustermann mkustermann approved these changes

@iskakaushik iskakaushik Awaiting requested review from iskakaushik

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dcharkes @mkustermann @googlebot