Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Use iOS 16 APIs to rotate orientation #36874

Merged
merged 1 commit into from
Oct 20, 2022
Merged

Use iOS 16 APIs to rotate orientation #36874

merged 1 commit into from
Oct 20, 2022

Conversation

jmagman
Copy link
Member

@jmagman jmagman commented Oct 19, 2022

On iOS 16:

BUG IN CLIENT OF UIKIT: Setting UIDevice.orientation is not supported. Please use UIWindowScene.requestGeometryUpdate(_:)

Fixes flutter/flutter#111587

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jmagman jmagman self-assigned this Oct 19, 2022
@jmagman jmagman marked this pull request as ready for review October 20, 2022 01:03
hellohuanlin
hellohuanlin approved these changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@hellohuanlin hellohuanlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx for fixing it 👍

@soarescaique
Copy link

I have tested the changes. It fixes Issue https://github.com/flutter/flutter/issues/111587. Thank you so much for the help. Well done

@jmagman jmagman added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 20, 2022
@auto-submit auto-submit bot merged commit 69f2bc8 into flutter:main Oct 20, 2022
@jmagman jmagman deleted the rotate branch October 20, 2022 17:35
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 20, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 20, 2022
@engine-flutter-autoroll
69f2bc881 Use iOS 16 APIs to rotate orientation (flutter/engine#36874)
652f33c
CaseyHillers pushed a commit to CaseyHillers/engine that referenced this pull request Oct 31, 2022
Revert "Use iOS 16 APIs to rotate orientation (flutter#36874)"
bf4acc7 
This reverts commit 69f2bc8.
auto-submit bot pushed a commit that referenced this pull request Oct 31, 2022
Revert "Use iOS 16 APIs to rotate orientation (#36874)" (#37165)
32d2d93
CaseyHillers pushed a commit to CaseyHillers/engine that referenced this pull request Nov 1, 2022
Revert "Use iOS 16 APIs to rotate orientation (flutter#36874)" (flutt…
dee9685 
…er#37165)
CaseyHillers pushed a commit that referenced this pull request Nov 1, 2022
[releases] Revert "Use iOS 16 APIs to rotate orientation (#36874)" (#…
72418b7 
…37165) (#37190)
CaseyHillers pushed a commit that referenced this pull request Nov 1, 2022
[release] Revert "Migrate darwin common "framework_shared" target to …
6244d76 
…ARC (#37049)" (#37195)

* Revert "Use iOS 16 APIs to rotate orientation (#36874)" (#37165)

* Revert "Migrate darwin common "framework_shared" target to ARC (#37049)"

This reverts commit 866b670.
@jmagman jmagman restored the rotate branch November 4, 2022 00:23
@jmagman jmagman mentioned this pull request Nov 4, 2022
Merged
8 tasks
This was referenced Dec 12, 2022
Closed
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hellohuanlin hellohuanlin hellohuanlin approved these changes

@cyanglaz cyanglaz Awaiting requested review from cyanglaz

Assignees

@jmagman jmagman

Labels
autosubmit Merge PR when tree becomes green via auto submit App platform-ios
Projects
None yet
Milestone
No milestone
3 participants
@jmagman @soarescaique @hellohuanlin