Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Revert "Use iOS 16 APIs to rotate orientation (#36874)" #37165

Merged
merged 1 commit into from
Oct 31, 2022
Merged

Revert "Use iOS 16 APIs to rotate orientation (#36874)" #37165

merged 1 commit into from
Oct 31, 2022

Conversation

CaseyHillers
Copy link
Contributor

@CaseyHillers CaseyHillers commented Oct 31, 2022 •
edited
Loading

This reverts commit 69f2bc8.

Googlers, see b/256523098. tl;dr is internally our build isn't ready to support XCode 14

jiahaog
jiahaog approved these changes Oct 31, 2022
View reviewed changes
Copy link
Member

@jiahaog jiahaog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably add more info to the PR description on why we are reverting this :)

@CaseyHillers
Copy link
Contributor Author

We should probably add more info to the PR description on why we are reverting this :)

Done :-)

@CaseyHillers CaseyHillers added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 31, 2022
@auto-submit auto-submit bot merged commit 32d2d93 into flutter:main Oct 31, 2022
@CaseyHillers CaseyHillers deleted the revert-ios-16 branch October 31, 2022 05:27
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 31, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 31, 2022
@engine-flutter-autoroll
32d2d937b Revert "Use iOS 16 APIs to rotate orientation (flutter#36874)…
5a1e024 
…" (flutter/engine#37165)
CaseyHillers pushed a commit to CaseyHillers/engine that referenced this pull request Nov 1, 2022
Revert "Use iOS 16 APIs to rotate orientation (flutter#36874)" (flutt…
dee9685 
…er#37165)
CaseyHillers pushed a commit that referenced this pull request Nov 1, 2022
[releases] Revert "Use iOS 16 APIs to rotate orientation (#36874)" (#…
72418b7 
…37165) (#37190)
CaseyHillers pushed a commit that referenced this pull request Nov 1, 2022
[release] Revert "Migrate darwin common "framework_shared" target to …
6244d76 
…ARC (#37049)" (#37195)

* Revert "Use iOS 16 APIs to rotate orientation (#36874)" (#37165)

* Revert "Migrate darwin common "framework_shared" target to ARC (#37049)"

This reverts commit 866b670.
This was referenced Nov 1, 2022
Closed
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jiahaog jiahaog jiahaog approved these changes

@jmagman jmagman Awaiting requested review from jmagman

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App platform-ios
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CaseyHillers @jiahaog