Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Adds direction to SemanticsFlag that ensures flutter_test is up to date with the latest flags #37046

Conversation

pdblasi-google
Copy link
Contributor

@pdblasi-google pdblasi-google commented Oct 26, 2022

As part of flutter/flutter #107866, more functionality for testing semantics was added. Part of this was simulatedAccessibilityTraversal, which is dependent on knowing what flags are important for accessibility. The comments noting what need to be updated when SemanticsFlags are changed now include the relevant field to update for tests to remain accurate as well.

Relates to flutter/flutter #107866

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the [CLA].
  • All existing and new tests are passing.

…date with the latest flags

As part of #107866, more functionality for testing semantics was added. Part of this was `simulatedAccessibilityTraversal`, which is dependent on knowing what flags are important for accessibility. The comments noting what need to be updated when SemanticsFlags are changed now include the relevent field to update for tests to remain accurate as well.
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hixie
Copy link
Contributor

Hixie commented Oct 26, 2022

test-exempt: only affected comments

@pdblasi-google pdblasi-google marked this pull request as draft October 26, 2022 18:25
@pdblasi-google
Copy link
Contributor Author

Changed to a draft until flutter/flutter #133133 is merged.

@flutter-dashboard
Copy link

This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again.

@pdblasi-google pdblasi-google marked this pull request as ready for review October 26, 2022 20:24
@pdblasi-google pdblasi-google added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 26, 2022
@auto-submit auto-submit bot merged commit 91c8221 into flutter:main Oct 26, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 26, 2022
@pdblasi-google pdblasi-google deleted the issues/107866-TestingSemanticsOrdering branch February 14, 2023 22:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
autosubmit Merge PR when tree becomes green via auto submit App needs tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants