Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Adds direction to SemanticsFlag that ensures flutter_test is up to date with the latest flags #37046

Merged
merged 1 commit into from
Oct 26, 2022
Merged

Adds direction to SemanticsFlag that ensures flutter_test is up to date with the latest flags #37046

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions lib/ui/semantics.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,9 @@ class SemanticsAction {
//
// When changes are made to this class, the equivalent APIs in
// `lib/ui/semantics/semantics_node.h` and in each of the embedders *must* be
// updated.
// updated. If the change affects the visibility of a [SemanticsNode] to
// accessibility services, `flutter_test/controller.dart#SemanticsController._importantFlags`
// must be updated as well.
class SemanticsFlag {
const SemanticsFlag._(this.index) : assert(index != null);

Expand Down Expand Up @@ -324,7 +326,10 @@ class SemanticsFlag {
// value in testing/dart/semantics_test.dart, or tests will fail. Also,
// please update the Flag enum in
// flutter/shell/platform/android/io/flutter/view/AccessibilityBridge.java,
// and the SemanticsFlag class in lib/web_ui/lib/semantics.dart.
// and the SemanticsFlag class in lib/web_ui/lib/semantics.dart. If the new flag
// affects the visibility of a [SemanticsNode] to accessibility services,
// `flutter_test/controller.dart#SemanticsController._importantFlags`
// must be updated as well.

/// The semantics node has the quality of either being "checked" or "unchecked".
///
Expand Down