Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[web] Improve CPU usage when building wasm_release #37294

Merged
merged 3 commits into from
Nov 4, 2022
Merged

[web] Improve CPU usage when building wasm_release #37294

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
47cd37c
[web] Improve CPU usage when building wasm_release
mdebbar Nov 3, 2022
a1fa891
use --offline mode
mdebbar Nov 3, 2022
0a3567c
make the change in tools/gn instead
mdebbar Nov 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion tools/gn
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,11 @@ def to_gn_args(args):
('cygwin', 'win')):
goma_home_dir = os.path.join('c:\\', 'src', 'goma', 'goma-win64')

if args.goma and goma_dir:
if args.target_os == 'wasm' or args.web:
gn_args['use_goma'] = False
gn_args['goma_dir'] = None
print('Disabling GOMA for wasm builds, it is not supported yet.')
elif args.goma and goma_dir:
gn_args['use_goma'] = True
gn_args['goma_dir'] = goma_dir
elif args.goma and os.path.exists(goma_home_dir):
Expand Down