This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[web] Improve CPU usage when building wasm_release #37294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
ditman
reviewed
Nov 3, 2022
lib/web_ui/dev/build.dart
Outdated
Comment on lines
133
to
140
| 'autoninja', | ||
| // When build the wasm target that includes CanvasKit, we need to use | ||
| // `ninja` directly to avoid having a high `-j` value that could | ||
| // potentially slow down the entire machine because emscripten doesn't use | ||
| // goma. | ||
| host ? 'autoninja' : 'ninja', |
There was a problem hiding this comment.
'autoninja',
if (!host)
'--offline',may do the trick? That instructs autoninja to not look for goma, so it'll default to whatever J it deems good for local builds.
There was a problem hiding this comment.
--offline did the trick!
eyebrowsoffire
suggested changes
Nov 3, 2022
eyebrowsoffire
removed
the
autosubmit
|
test-exempt: configuration change |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 4, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 4, 2022
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 4, 2022
…114667) * 49acbfb08 Make iOS PlatformView to reuse VisualEffectView when possible. (flutter/engine#37263) * 48f31a539 Roll Skia from 8e48bb8ea52e to 10acfb0efbc9 (2 revisions) (flutter/engine#37300) * af61d4092 [Impeller] Add non-rrect polygon to shadow test (flutter/engine#37296) * 97fb982f3 [web] Improve CPU usage when building wasm_release (flutter/engine#37294) * ca0755adc Roll Skia from 10acfb0efbc9 to b8209dce9a48 (1 revision) (flutter/engine#37303) * 44398ccf5 Make hot reload work (flutter/engine#37304) * 69a275300 Roll Fuchsia Mac SDK from mOXbRSWGSdWRXIefR... to JKfnEvEVIL_Cg3_9f... (flutter/engine#37305)
schwa423
pushed a commit
to schwa423/engine
that referenced
this pull request
Nov 16, 2022
* [web] Improve CPU usage when building wasm_release * use --offline mode * make the change in tools/gn instead
shogohida
pushed a commit
to shogohida/flutter
that referenced
this pull request
Dec 7, 2022
…lutter#114667) * 49acbfb08 Make iOS PlatformView to reuse VisualEffectView when possible. (flutter/engine#37263) * 48f31a539 Roll Skia from 8e48bb8ea52e to 10acfb0efbc9 (2 revisions) (flutter/engine#37300) * af61d4092 [Impeller] Add non-rrect polygon to shadow test (flutter/engine#37296) * 97fb982f3 [web] Improve CPU usage when building wasm_release (flutter/engine#37294) * ca0755adc Roll Skia from 10acfb0efbc9 to b8209dce9a48 (1 revision) (flutter/engine#37303) * 44398ccf5 Make hot reload work (flutter/engine#37304) * 69a275300 Roll Fuchsia Mac SDK from mOXbRSWGSdWRXIefR... to JKfnEvEVIL_Cg3_9f... (flutter/engine#37305)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doing a
felt build(without--host) causes high cpu usage for some people (including me and @htoor3). This is because our build tries to usegomawith a high parallelization factor that all ends up happening in the local machine becausegomadoesn't supportemscriptenyet.This PR disables
gomafor wasm/web builds.