This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Add non-rrect polygon to shadow test #37296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdero
force-pushed
the
bdero/shar-shadow-test
branch
from
18a7409 to
b571563
Compare
chinmaygarde
approved these changes
Nov 3, 2022
| @@ -676,7 +698,7 @@ TEST_P(DisplayListTest, CanDrawShadow) { | |||
| } | |||
|
|
|||
| ASSERT_TRUE(OpenPlaygroundHere(builder.Build())); | |||
| } | |||
| } // namespace testing | |||
There was a problem hiding this comment.
Nit: Don't think this is the end of the namespace. Perhaps your editor is confused?
There was a problem hiding this comment.
Whoops! I trigger clang format runs in the middle of writing code often. Fixed.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 4, 2022
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 4, 2022
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 4, 2022
…114667) * 49acbfb08 Make iOS PlatformView to reuse VisualEffectView when possible. (flutter/engine#37263) * 48f31a539 Roll Skia from 8e48bb8ea52e to 10acfb0efbc9 (2 revisions) (flutter/engine#37300) * af61d4092 [Impeller] Add non-rrect polygon to shadow test (flutter/engine#37296) * 97fb982f3 [web] Improve CPU usage when building wasm_release (flutter/engine#37294) * ca0755adc Roll Skia from 10acfb0efbc9 to b8209dce9a48 (1 revision) (flutter/engine#37303) * 44398ccf5 Make hot reload work (flutter/engine#37304) * 69a275300 Roll Fuchsia Mac SDK from mOXbRSWGSdWRXIefR... to JKfnEvEVIL_Cg3_9f... (flutter/engine#37305)
schwa423
pushed a commit
to schwa423/engine
that referenced
this pull request
Nov 16, 2022
* Add non-rrect shadow to test * Remove weird namespace comment * Remove constant
shogohida
pushed a commit
to shogohida/flutter
that referenced
this pull request
Dec 7, 2022
…lutter#114667) * 49acbfb08 Make iOS PlatformView to reuse VisualEffectView when possible. (flutter/engine#37263) * 48f31a539 Roll Skia from 8e48bb8ea52e to 10acfb0efbc9 (2 revisions) (flutter/engine#37300) * af61d4092 [Impeller] Add non-rrect polygon to shadow test (flutter/engine#37296) * 97fb982f3 [web] Improve CPU usage when building wasm_release (flutter/engine#37294) * ca0755adc Roll Skia from 10acfb0efbc9 to b8209dce9a48 (1 revision) (flutter/engine#37303) * 44398ccf5 Make hot reload work (flutter/engine#37304) * 69a275300 Roll Fuchsia Mac SDK from mOXbRSWGSdWRXIefR... to JKfnEvEVIL_Cg3_9f... (flutter/engine#37305)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This demonstrates remaining shadow quality issues caused by the gaussian blur downsampling curve.