Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Fix signature logic in license tool #38363

Merged
merged 1 commit into from
Dec 19, 2022
Merged

Fix signature logic in license tool #38363

merged 1 commit into from
Dec 19, 2022

Conversation

Hixie
Copy link
Contributor

@Hixie Hixie commented Dec 16, 2022

No description provided.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@Hixie
Copy link
Contributor Author

Hixie commented Dec 16, 2022

test-exempt: optimization

...the real problem here is that there's only one really valid test and that's checking that it actually works on CI. :-)

@Hixie Hixie added the autosubmit Merge PR when tree becomes green via auto submit App label Dec 19, 2022
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Dec 19, 2022
@auto-submit
Copy link
Contributor

auto-submit bot commented Dec 19, 2022

auto label is removed for flutter/engine, pr: 38363, Failed to merge pr#: 38363 with Pull request could not be merged: Resource not accessible by integration.

@zanderso
Copy link
Member

Autosubmit failed on flutter/flutter#117318. Landing manually.

@zanderso zanderso merged commit 955a35a into flutter:main Dec 19, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 19, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 20, 2022
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Dec 20, 2022
…117354)

* 343166954 Bump ossf/scorecard-action from 2.0.4 to 2.1.1 (flutter/engine#38406)

* 955a35a3b Fix signature logic in license tool (flutter/engine#38363)

* 6de29d1cb [macOS] Update FlutterView layer scale when backing properties change (flutter/engine#38402)
loic-sharma pushed a commit to loic-sharma/flutter-engine that referenced this pull request Jan 3, 2023
gspencergoog pushed a commit to gspencergoog/flutter that referenced this pull request Jan 19, 2023
…lutter#117354)

* 343166954 Bump ossf/scorecard-action from 2.0.4 to 2.1.1 (flutter/engine#38406)

* 955a35a3b Fix signature logic in license tool (flutter/engine#38363)

* 6de29d1cb [macOS] Update FlutterView layer scale when backing properties change (flutter/engine#38402)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants