This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[macOS] Update FlutterView layer scale when backing properties change #38402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@knopp Thanks for the quick fix! Looks like the license script is unhappy. Could you take a look? |
a-wallen
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/engine, pr: 38402, Failed to merge pr#: 38402 with Pull request could not be merged: Resource not accessible by integration. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 20, 2022
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 20, 2022
…117354) * 343166954 Bump ossf/scorecard-action from 2.0.4 to 2.1.1 (flutter/engine#38406) * 955a35a3b Fix signature logic in license tool (flutter/engine#38363) * 6de29d1cb [macOS] Update FlutterView layer scale when backing properties change (flutter/engine#38402)
loic-sharma
pushed a commit
to loic-sharma/flutter-engine
that referenced
this pull request
Jan 3, 2023
gspencergoog
pushed a commit
to gspencergoog/flutter
that referenced
this pull request
Jan 19, 2023
…lutter#117354) * 343166954 Bump ossf/scorecard-action from 2.0.4 to 2.1.1 (flutter/engine#38406) * 955a35a3b Fix signature logic in license tool (flutter/engine#38363) * 6de29d1cb [macOS] Update FlutterView layer scale when backing properties change (flutter/engine#38402)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes problem introduced in #37789.
CALayer scale is used to position surfaces, but the scale is not updated when backing window properties change.
Implementing CALayer's delegate (FlutterView) [layer:shouldInheritContentsScale:fromWindow:] takes care of this.
Fixes flutter/flutter#117247
List which issues are fixed by this PR. You must list at least one issue.
If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.