[Impeller] Assign subpass depth on restore rather than creation. #50626
Conversation
auto-submit
bot
removed
the
autosubmit
|
auto label is removed for flutter/engine/50626, due to - The status or check suite Mac mac_host_engine has failed. Please fix the issues identified (or deflake) before re-applying this label. |
bdero
force-pushed
the
bdero/fix-savelayer-depth
branch
2 times, most recently
from
92afb30 to
7ba1a30
Compare
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. |
bdero
force-pushed
the
bdero/fix-savelayer-depth
branch
from
7ba1a30 to
af0bff2
Compare
|
Golden file changes are available for triage from new commit, Click here to view. |
The subpass depth is used for drawing the texture to the parent pass. So it needs a depth > all of the clips contained within the subpass. Also correct the way we're assigning the depth value in shaders.
bdero
force-pushed
the
bdero/fix-savelayer-depth
branch
from
393ade6 to
8860b27
Compare
|
This is a bit wacky, but the pipelines seem to be getting an alternative depth write compare options on all the backends on just CI somehow. It's happening for all 3 backends so the issue is going to be a high level thing. I'll probably figure it out after a couple more print debugging iterations. Might scatter around a few more sensible debug time checks while I'm at it as well since there's some potential for subtle mistakes that are hard to debug. |
|
(errors on CI right now are just due to my print debugging) |
|
This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again. |
|
I had missed a couple of spots when initially distributing the depth to the shaders, and the previous behavior of passing the depth through the ortho projection was covering it up. |
bdero
added
autosubmit
…143652) flutter/engine@e51d4f1...c807aea 2024-02-17 [email protected] Roll Skia from bb61c2b4614e to 0d2dbf53aef6 (3 revisions) (flutter/engine#50744) 2024-02-17 [email protected] [Impeller] add additional setup method that caches more pipelines, warms internal shader code (flutter/engine#50521) 2024-02-17 [email protected] [Impeller] Assign subpass depth on restore rather than creation. (flutter/engine#50626) 2024-02-17 [email protected] Roll Dart SDK from fa66195a3814 to 6d659f880394 (1 revision) (flutter/engine#50739) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
The subpass depth is used for drawing the texture to the parent pass. So it needs a depth > all of the clips contained within the subpass.
Also correct the way we're assigning the depth value in shaders.