Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Impeller] makes bgra10xr test more comprehensive #53320

Merged
merged 5 commits into from
Jun 11, 2024
Merged

[Impeller] makes bgra10xr test more comprehensive #53320

merged 5 commits into from
Jun 11, 2024

Conversation

gaaclarke
Copy link
Member

@gaaclarke gaaclarke commented Jun 10, 2024 •
edited
Loading

fixes flutter/flutter#149946

depends on:

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

jbeich pushed a commit to jbeich/skcms that referenced this pull request Jun 11, 2024
@gaaclarke
Fixed BGRA10XR to have padding be 6 *least* significant bits.
bc467ef 
This is verified in the more robust integration test: flutter/engine#53320

Bug: skia:flutter/flutter#149946
Change-Id: I57fb34e3cc02db63c3125faee7e1846d9b6f2583
Reviewed-on: https://skia-review.googlesource.com/c/skcms/+/864516
Reviewed-by: Brian Osman <[email protected]>
Commit-Queue: Brian Osman <[email protected]>
hubot pushed a commit to google/skia that referenced this pull request Jun 11, 2024
@gaaclarke
Fixed destination pixel format when png encoding bgra10_xr.
e6720e2 
depends on https://skia-review.googlesource.com/c/skcms/+/864516
verified in integration test at: flutter/engine#53320

Bug: flutter/flutter#149946
Change-Id: Ia1bd18fe3fb69a3ebe8725d3fee0d8ed4f710ffb
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/864536
Reviewed-by: Brian Osman <[email protected]>
Commit-Queue: Aaron Clarke <[email protected]>
@gaaclarke gaaclarke force-pushed the beefier-bgra-png-test branch from 7bc6f1b to 6275461 Compare June 11, 2024 17:53
@gaaclarke gaaclarke marked this pull request as ready for review June 11, 2024 18:10
@gaaclarke gaaclarke force-pushed the beefier-bgra-png-test branch from 7c42d2a to 14569fd Compare June 11, 2024 18:46
@gaaclarke gaaclarke requested a review from jonahwilliams June 11, 2024 18:47
jonahwilliams
jonahwilliams approved these changes Jun 11, 2024
View reviewed changes
Copy link
Member

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaaclarke gaaclarke added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 11, 2024
@auto-submit Auto-submit
Copy link
Contributor

auto-submit bot commented Jun 11, 2024

auto label is removed for flutter/engine/53320, due to - The status or check suite Linux linux_fuchsia has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 11, 2024
@gaaclarke gaaclarke added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 11, 2024
@auto-submit auto-submit bot merged commit 73f81bf into flutter:main Jun 11, 2024
29 checks passed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 12, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 12, 2024
@engine-flutter-autoroll
73f81bf38 [Impeller] makes bgra10xr test more comprehensive (flutter/…
866150e 
…engine#53320)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 12, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 12, 2024
@engine-flutter-autoroll
73f81bf38 [Impeller] makes bgra10xr test more comprehensive (flutter/…
e34df91 
…engine#53320)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 12, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 12, 2024
@engine-flutter-autoroll
73f81bf38 [Impeller] makes bgra10xr test more comprehensive (flutter/…
d38d715 
…engine#53320)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 12, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 12, 2024
@engine-flutter-autoroll
73f81bf38 [Impeller] makes bgra10xr test more comprehensive (flutter/…
0947a04 
…engine#53320)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 12, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 12, 2024
@engine-flutter-autoroll
73f81bf38 [Impeller] makes bgra10xr test more comprehensive (flutter/…
7a3a095 
…engine#53320)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 12, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 12, 2024
@engine-flutter-autoroll
73f81bf38 [Impeller] makes bgra10xr test more comprehensive (flutter/…
b2545f8 
…engine#53320)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 12, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 12, 2024
@engine-flutter-autoroll
73f81bf38 [Impeller] makes bgra10xr test more comprehensive (flutter/…
1eee0a7 
…engine#53320)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 13, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 13, 2024
@engine-flutter-autoroll
73f81bf38 [Impeller] makes bgra10xr test more comprehensive (flutter/…
70bfe9f 
…engine#53320)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 13, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 13, 2024
@engine-flutter-autoroll
73f81bf38 [Impeller] makes bgra10xr test more comprehensive (flutter/…
e21a223 
…engine#53320)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 13, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 13, 2024
@engine-flutter-autoroll
73f81bf38 [Impeller] makes bgra10xr test more comprehensive (flutter/…
7a4bfe1 
…engine#53320)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 13, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 13, 2024
@engine-flutter-autoroll
73f81bf38 [Impeller] makes bgra10xr test more comprehensive (flutter/…
2bc6aef 
…engine#53320)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 13, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 13, 2024
@engine-flutter-autoroll
73f81bf38 [Impeller] makes bgra10xr test more comprehensive (flutter/…
a0768c4 
…engine#53320)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 13, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 13, 2024
@engine-flutter-autoroll
73f81bf38 [Impeller] makes bgra10xr test more comprehensive (flutter/…
a56b484 
…engine#53320)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 13, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 13, 2024
@engine-flutter-autoroll
73f81bf38 [Impeller] makes bgra10xr test more comprehensive (flutter/…
b1604fc 
…engine#53320)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 13, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 13, 2024
@engine-flutter-autoroll
73f81bf38 [Impeller] makes bgra10xr test more comprehensive (flutter/…
adea201 
…engine#53320)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 13, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 13, 2024
@engine-flutter-autoroll
73f81bf38 [Impeller] makes bgra10xr test more comprehensive (flutter/…
929c5a1 
…engine#53320)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 13, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 13, 2024
@engine-flutter-autoroll
73f81bf38 [Impeller] makes bgra10xr test more comprehensive (flutter/…
9679959 
…engine#53320)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 13, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 13, 2024
@engine-flutter-autoroll
73f81bf38 [Impeller] makes bgra10xr test more comprehensive (flutter/…
b17c2e8 
…engine#53320)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 13, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 13, 2024
@engine-flutter-autoroll
73f81bf38 [Impeller] makes bgra10xr test more comprehensive (flutter/…
3c0fb5d 
…engine#53320)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 13, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 13, 2024
@engine-flutter-autoroll
73f81bf38 [Impeller] makes bgra10xr test more comprehensive (flutter/…
58b4047 
…engine#53320)
auto-submit bot pushed a commit to flutter/flutter that referenced this pull request Jun 13, 2024
@engine-flutter-autoroll
Roll Flutter Engine from c7fcbfce608f to 4cb3025d3abf (28 revisions) (#…
01db23b 
…150199)

flutter/engine@c7fcbfc...4cb3025

2024-06-13 [email protected] Roll Skia from 0fe7f7ac43c5 to ecc64fb82374 (1 revision) (flutter/engine#53374)
2024-06-13 [email protected] Roll Skia from 9ea9f37e8e1d to 0fe7f7ac43c5 (1 revision) (flutter/engine#53373)
2024-06-13 [email protected] Roll Skia from b12af56eb100 to 9ea9f37e8e1d (1 revision) (flutter/engine#53372)
2024-06-13 [email protected] Roll Skia from 704f70b7d756 to b12af56eb100 (1 revision) (flutter/engine#53371)
2024-06-13 [email protected] Roll Skia from 69a53db434a6 to 704f70b7d756 (2 revisions) (flutter/engine#53370)
2024-06-13 [email protected] Roll Skia from b2f163ae11bf to 69a53db434a6 (8 revisions) (flutter/engine#53365)
2024-06-13 [email protected] [Impeller] Move Gradient tests to display list. (flutter/engine#53345)
2024-06-13 [email protected] Roll Fuchsia Linux SDK from 5VG7IYkpANkfxMKYx... to pGxbL7JoNb3yAYFw4... (flutter/engine#53363)
2024-06-13 [email protected] Roll Skia from be6a57569a92 to b2f163ae11bf (5 revisions) (flutter/engine#53357)
2024-06-13 [email protected] Give mac_host_engine tests a longer timeout and allow to run on Mac-14 (flutter/engine#53355)
2024-06-13 [email protected] 'Starter Project': port planet fragment shader to impeller tests (flutter/engine#53362)
2024-06-12 [email protected] Roll Skia from 1ba0c3ebc7a5 to be6a57569a92 (1 revision) (flutter/engine#53353)
2024-06-12 [email protected] Roll Dart SDK from 24fbead7105d to aa2265e5a192 (1 revision) (flutter/engine#53352)
2024-06-12 [email protected] Roll Skia from 52d829ac6a0b to 1ba0c3ebc7a5 (1 revision) (flutter/engine#53351)
2024-06-12 [email protected] Roll Skia from 5bfbacc89543 to 52d829ac6a0b (1 revision) (flutter/engine#53350)
2024-06-12 [email protected] Roll Skia from 51eabd0d1e44 to 5bfbacc89543 (1 revision) (flutter/engine#53349)
2024-06-12 [email protected] Roll Dart SDK from b61536f05f99 to 24fbead7105d (1 revision) (flutter/engine#53348)
2024-06-12 [email protected] Roll Dart SDK from 269125c33a35 to b61536f05f99 (1 revision) (flutter/engine#53347)
2024-06-12 [email protected] [Impeller] disabling the color write mask seems to improve performance on iOS compared to just the blend options. (flutter/engine#53322)
2024-06-11 [email protected] Roll Fuchsia Linux SDK from LS0Ff8PwQEGXzO0iA... to 5VG7IYkpANkfxMKYx... (flutter/engine#53346)
2024-06-11 [email protected] Roll Dart SDK from ab4d5a0b789d to 269125c33a35 (1 revision) (flutter/engine#53344)
2024-06-11 [email protected] [Impeller] makes bgra10xr test more comprehensive (flutter/engine#53320)
2024-06-11 [email protected] Roll Skia from af907b24d873 to 51eabd0d1e44 (1 revision) (flutter/engine#53343)
2024-06-11 [email protected] [Impeller] add missing position to exp canvas text. (flutter/engine#53339)
2024-06-11 [email protected] Roll Skia from 4cbc1129e587 to af907b24d873 (1 revision) (flutter/engine#53341)
2024-06-11 [email protected] Revert "[web] switch from .didGain/LoseAccessibilityFocus to .focus (â�¦ (flutter/engine#53342)
2024-06-11 [email protected] [Impeller] move some tests from aiks to display list. (flutter/engine#53336)
2024-06-11 [email protected] Roll Skia from b5f974ec2dcd to 4cbc1129e587 (1 revision) (flutter/engine#53340)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from LS0Ff8PwQEGX to pGxbL7JoNb3y

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
victorsanni pushed a commit to victorsanni/flutter that referenced this pull request Jun 14, 2024
@engine-flutter-autoroll @victorsanni
Roll Flutter Engine from c7fcbfce608f to 4cb3025d3abf (28 revisions) (f…
bd6de6d 
…lutter#150199)

flutter/engine@c7fcbfc...4cb3025

2024-06-13 [email protected] Roll Skia from 0fe7f7ac43c5 to ecc64fb82374 (1 revision) (flutter/engine#53374)
2024-06-13 [email protected] Roll Skia from 9ea9f37e8e1d to 0fe7f7ac43c5 (1 revision) (flutter/engine#53373)
2024-06-13 [email protected] Roll Skia from b12af56eb100 to 9ea9f37e8e1d (1 revision) (flutter/engine#53372)
2024-06-13 [email protected] Roll Skia from 704f70b7d756 to b12af56eb100 (1 revision) (flutter/engine#53371)
2024-06-13 [email protected] Roll Skia from 69a53db434a6 to 704f70b7d756 (2 revisions) (flutter/engine#53370)
2024-06-13 [email protected] Roll Skia from b2f163ae11bf to 69a53db434a6 (8 revisions) (flutter/engine#53365)
2024-06-13 [email protected] [Impeller] Move Gradient tests to display list. (flutter/engine#53345)
2024-06-13 [email protected] Roll Fuchsia Linux SDK from 5VG7IYkpANkfxMKYx... to pGxbL7JoNb3yAYFw4... (flutter/engine#53363)
2024-06-13 [email protected] Roll Skia from be6a57569a92 to b2f163ae11bf (5 revisions) (flutter/engine#53357)
2024-06-13 [email protected] Give mac_host_engine tests a longer timeout and allow to run on Mac-14 (flutter/engine#53355)
2024-06-13 [email protected] 'Starter Project': port planet fragment shader to impeller tests (flutter/engine#53362)
2024-06-12 [email protected] Roll Skia from 1ba0c3ebc7a5 to be6a57569a92 (1 revision) (flutter/engine#53353)
2024-06-12 [email protected] Roll Dart SDK from 24fbead7105d to aa2265e5a192 (1 revision) (flutter/engine#53352)
2024-06-12 [email protected] Roll Skia from 52d829ac6a0b to 1ba0c3ebc7a5 (1 revision) (flutter/engine#53351)
2024-06-12 [email protected] Roll Skia from 5bfbacc89543 to 52d829ac6a0b (1 revision) (flutter/engine#53350)
2024-06-12 [email protected] Roll Skia from 51eabd0d1e44 to 5bfbacc89543 (1 revision) (flutter/engine#53349)
2024-06-12 [email protected] Roll Dart SDK from b61536f05f99 to 24fbead7105d (1 revision) (flutter/engine#53348)
2024-06-12 [email protected] Roll Dart SDK from 269125c33a35 to b61536f05f99 (1 revision) (flutter/engine#53347)
2024-06-12 [email protected] [Impeller] disabling the color write mask seems to improve performance on iOS compared to just the blend options. (flutter/engine#53322)
2024-06-11 [email protected] Roll Fuchsia Linux SDK from LS0Ff8PwQEGXzO0iA... to 5VG7IYkpANkfxMKYx... (flutter/engine#53346)
2024-06-11 [email protected] Roll Dart SDK from ab4d5a0b789d to 269125c33a35 (1 revision) (flutter/engine#53344)
2024-06-11 [email protected] [Impeller] makes bgra10xr test more comprehensive (flutter/engine#53320)
2024-06-11 [email protected] Roll Skia from af907b24d873 to 51eabd0d1e44 (1 revision) (flutter/engine#53343)
2024-06-11 [email protected] [Impeller] add missing position to exp canvas text. (flutter/engine#53339)
2024-06-11 [email protected] Roll Skia from 4cbc1129e587 to af907b24d873 (1 revision) (flutter/engine#53341)
2024-06-11 [email protected] Revert "[web] switch from .didGain/LoseAccessibilityFocus to .focus (â�¦ (flutter/engine#53342)
2024-06-11 [email protected] [Impeller] move some tests from aiks to display list. (flutter/engine#53336)
2024-06-11 [email protected] Roll Skia from b5f974ec2dcd to 4cbc1129e587 (1 revision) (flutter/engine#53340)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from LS0Ff8PwQEGX to pGxbL7JoNb3y

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
victorsanni pushed a commit to victorsanni/flutter that referenced this pull request Jun 14, 2024
@engine-flutter-autoroll @victorsanni
Roll Flutter Engine from c7fcbfce608f to 4cb3025d3abf (28 revisions) (f…
cd3166a 
…lutter#150199)

flutter/engine@c7fcbfc...4cb3025

2024-06-13 [email protected] Roll Skia from 0fe7f7ac43c5 to ecc64fb82374 (1 revision) (flutter/engine#53374)
2024-06-13 [email protected] Roll Skia from 9ea9f37e8e1d to 0fe7f7ac43c5 (1 revision) (flutter/engine#53373)
2024-06-13 [email protected] Roll Skia from b12af56eb100 to 9ea9f37e8e1d (1 revision) (flutter/engine#53372)
2024-06-13 [email protected] Roll Skia from 704f70b7d756 to b12af56eb100 (1 revision) (flutter/engine#53371)
2024-06-13 [email protected] Roll Skia from 69a53db434a6 to 704f70b7d756 (2 revisions) (flutter/engine#53370)
2024-06-13 [email protected] Roll Skia from b2f163ae11bf to 69a53db434a6 (8 revisions) (flutter/engine#53365)
2024-06-13 [email protected] [Impeller] Move Gradient tests to display list. (flutter/engine#53345)
2024-06-13 [email protected] Roll Fuchsia Linux SDK from 5VG7IYkpANkfxMKYx... to pGxbL7JoNb3yAYFw4... (flutter/engine#53363)
2024-06-13 [email protected] Roll Skia from be6a57569a92 to b2f163ae11bf (5 revisions) (flutter/engine#53357)
2024-06-13 [email protected] Give mac_host_engine tests a longer timeout and allow to run on Mac-14 (flutter/engine#53355)
2024-06-13 [email protected] 'Starter Project': port planet fragment shader to impeller tests (flutter/engine#53362)
2024-06-12 [email protected] Roll Skia from 1ba0c3ebc7a5 to be6a57569a92 (1 revision) (flutter/engine#53353)
2024-06-12 [email protected] Roll Dart SDK from 24fbead7105d to aa2265e5a192 (1 revision) (flutter/engine#53352)
2024-06-12 [email protected] Roll Skia from 52d829ac6a0b to 1ba0c3ebc7a5 (1 revision) (flutter/engine#53351)
2024-06-12 [email protected] Roll Skia from 5bfbacc89543 to 52d829ac6a0b (1 revision) (flutter/engine#53350)
2024-06-12 [email protected] Roll Skia from 51eabd0d1e44 to 5bfbacc89543 (1 revision) (flutter/engine#53349)
2024-06-12 [email protected] Roll Dart SDK from b61536f05f99 to 24fbead7105d (1 revision) (flutter/engine#53348)
2024-06-12 [email protected] Roll Dart SDK from 269125c33a35 to b61536f05f99 (1 revision) (flutter/engine#53347)
2024-06-12 [email protected] [Impeller] disabling the color write mask seems to improve performance on iOS compared to just the blend options. (flutter/engine#53322)
2024-06-11 [email protected] Roll Fuchsia Linux SDK from LS0Ff8PwQEGXzO0iA... to 5VG7IYkpANkfxMKYx... (flutter/engine#53346)
2024-06-11 [email protected] Roll Dart SDK from ab4d5a0b789d to 269125c33a35 (1 revision) (flutter/engine#53344)
2024-06-11 [email protected] [Impeller] makes bgra10xr test more comprehensive (flutter/engine#53320)
2024-06-11 [email protected] Roll Skia from af907b24d873 to 51eabd0d1e44 (1 revision) (flutter/engine#53343)
2024-06-11 [email protected] [Impeller] add missing position to exp canvas text. (flutter/engine#53339)
2024-06-11 [email protected] Roll Skia from 4cbc1129e587 to af907b24d873 (1 revision) (flutter/engine#53341)
2024-06-11 [email protected] Revert "[web] switch from .didGain/LoseAccessibilityFocus to .focus (â�¦ (flutter/engine#53342)
2024-06-11 [email protected] [Impeller] move some tests from aiks to display list. (flutter/engine#53336)
2024-06-11 [email protected] Roll Skia from b5f974ec2dcd to 4cbc1129e587 (1 revision) (flutter/engine#53340)

Also rolling transitive DEPS:
  fuchsia/sdk/core/linux-amd64 from LS0Ff8PwQEGX to pGxbL7JoNb3y

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jonahwilliams jonahwilliams jonahwilliams approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error occurs on real device when taking screenshot
2 participants
@gaaclarke @jonahwilliams